Update XLA #1614
Merged
Update XLA #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
reviewed
Jun 16, 2025
Co-authored-by: Paulo Valente <[email protected]>
|
@polvalente all good! |
Let me test this locally on CUDA later today before merging! |
|
Perfect! |
josevalim
reviewed
Jun 16, 2025
exla/c_src/exla/custom_calls/eigh.h
Outdated
There was a problem hiding this comment.
We already wanted to merge custom calls into the XLA project so we can decrease the compile time, let's take the opportunity and do it now?
There was a problem hiding this comment.
I already released new XLA. The update took long this time, so I didn't want to add extra stuff to postpone it even longer. Let's do it separately once we have more time to prioritise this :)
|
I've tried this PR with a 50xx card for a bit, and it looks good. |
|
@petrkozorezov fantastic, thank you for letting us know! |
polvalente
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps XLA to recent revision.
We were still using the oldest API for defining custom calls and now a bunch of deprecation errors have been logged. I went ahead and updated to the latest typed FFI API, which also simplified the MLIR generation nicely.
Closes #1599.