issue/14745 code

[ArthurG0]

No description provided.

[welcome]

Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS.

[sbc100]

@kripken @RReverser ?

[kripken]

Sorry for the delay here - @ArthurG0 , this looks good I think.

Can you add testing for it? Adding a little to the existing test should be enough, the one under tests/webidl/ (runnable with ./tests/runner test_webidl).

[ArthurG0]

@kripken @sbc100

Unfortunately, I can't even run the current tests without errors using the command you provided (./tests/runner test_webidl)

\system\lib\dlmalloc.c:35:1: error: static_assert failed due to requirement '(__alignof(max_align_t)) == 8'
      "max_align_t must be 8"
_Static_assert(MALLOC_ALIGNMENT == 8, "max_align_t must be 8");
^              ~~~~~~~~~~~~~~~~~~~~~
1 error generated.

is the error. I'm running it on my windows machine on both my own fork as well as main branch of the base repo.

Could you comment on this, have you encountered not being able to run the tests?

[sbc100]

That error looks like its because you are using an older version of llvm before we changed the max_align_t. Are you using emsdk to install emscripten? That is the recommended way to be sure you have the correct versions. Alternatively you could build llvm from tip-of-tree.

[ArthurG0]

Thank you, was able to update LLVM version and run the tests successfully, adding them to the PR

[kripken]

Looks like the webidl tests fail - hopefully that can be debugged locally?

Separately I see other failures, that may indicate this is not rebased on something new enough. Merging in latest main should help.

[kripken]

looks like a merge error here.

[stale]

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.