Remove shared.PYTHON. NFC #17197
Merged
Remove shared.PYTHON. NFC #17197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Jun 10, 2022
sbc100
force-pushed
the
remove_shared_python
branch
from
f5714d4 to
94b7af5
Compare
kripken
approved these changes
Jun 13, 2022
This was nothing more than an alias for sys.executable. While this is used a fair amount in testing, emscripten itself should not be forking python subprocesses itself, but instead using the launcher scripts. There is one place in emscripten where we do fork a python subprocess directly (when we run tools/wasm-sourcemap.py) and I'm not sure its worth adding a wrapper for that minor tool. For that one case I've added `-E` to match the changes we are planning to the launcher scripts: #16736
sbc100
force-pushed
the
remove_shared_python
branch
from
94b7af5 to
046fc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was nothing more than an alias for sys.executable. While this
is used a fair amount in testing, emscripten itself should not be
forking python subprocesses itself, but instead using the launcher
scripts.