feat(kconfig): Add option to kconfig #221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to change esptool reset mode
|
|
27-301
reviewed
Jun 11, 2018
| @@ -103,6 +103,8 @@ choice ESPTOOLPY_FLASHSIZE | |||
| help | |||
| SPI flash size, in megabytes | |||
|
|
|||
| config ESPTOOLPY_FLASHSIZE_1MB | |||
| bool "1 MB" | |||
There was a problem hiding this comment.
Modification for 1MB is not related with this PR.
Maybe we will not recommend to use 1MB flash, since the binary size is increased, and maybe larger than 512KB, 1MB flash cannot support OTA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to change esptool reset mode
issue: Soft reset after flash #191