Skip to content

feat(test): Enhance NVS test #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JakubAndrysek
Copy link
Collaborator

@JakubAndrysek JakubAndrysek commented Jun 18, 2025

Description of Change

This pull request introduces enhancements to the tests/validation/nvs module, focusing on extending the functionality of the NVS (Non-Volatile Storage) validation and improving test coverage. The changes include adding support for more data types, implementing value incrementation, and updating the test cases accordingly.

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with Wokwi on all available chips.

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 13aac76

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Test Results

144 files  144 suites   47m 29s ⏱️
 43 tests  42 ✅ 0 💤  1 ❌
443 runs  422 ✅ 0 💤 21 ❌

For more details on these failures, see this check.

Results for commit 13aac76.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the hil_test Run Hardware Tests label Jun 19, 2025
@JakubAndrysek
Copy link
Collaborator Author

@lucasssvaz
Copy link
Collaborator

All tests passed https://github.com/JakubAndrysek/arduino-esp32/actions/runs/15757180922

These are the compilation tests and not the runtime tests. Either way HW tests are passing and I've checked the wokwi run on your fork. Everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hil_test Run Hardware Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants