Skip to content

eth/catalyst: force sync of txpool before clearing subpools in Rollback #31228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

eth/catalyst: force sync of txpool before clearing subpools in Rollback #31228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbf934
Fix flakey behavior in simulated backend Rollback
dahu33 Feb 21, 2025
18faa25
Update core/txpool/txpool.go
dahu33 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/txpool/txpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ func (p *TxPool) Sync() error {

// Clear removes all tracked txs from the subpools.
func (p *TxPool) Clear() {
// Invoke Sync to ensure that txs pending addition don't get added to the pool after
// the subpools are subsequently cleared
p.Sync()
for _, subpool := range p.subpools {
subpool.Clear()
}
Expand Down