Skip to content

Remove nested describes to unbreak task-based testing #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jun 19, 2025

Fix issue where task based outputs do not work due to nested describe() calls. See Discord discussion.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Cool-Katt
Copy link
Contributor

/format

Copy link
Contributor

The "Format code" action has started running.

@Cool-Katt
Copy link
Contributor

Hello, bots? Anyone there?

/format

Copy link
Contributor

The "Format code" action has started running.

@Cool-Katt
Copy link
Contributor

@IsaacG can you format this on your end?
The bot command fails because it doesn't like that the branch is named main.

@SleeplessByte SleeplessByte merged commit 5eeee38 into exercism:main Jun 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants