Forbid running any scripts when webpack/jest/babel are installed directly

[gaearon]

We get too many issues with people trying to update these tools manually and completely breaking setups. We should just check for those dependencies and immediately crash with an explanation that it's not supported to declare them explicitly without ejecting.

[gaearon]

Alternatively we should probably be more resilient in how we resolve dependencies so that installing incompatible versions can't break us. I'll need to think more about this.

[viankakrisna]

how about packaging react-scripts using https://github.com/zeit/pkg? will it solve the problem?

[gaearon]

Potentially, and maybe help performance too. I’m interested in seeing a proof of concept.

[viankakrisna]

I've experimented with it before, but couldn't make it work... IIRC something to do with dynamic requires. Will bundling react-scripts into one file using webpack / rollup achieve similar results?

[viankakrisna]

tried using webpack, it also complains about dynamic requires require(variable) 😄 how does one compile nodejs app to one file with all this dynamic requires? It would be tiresome to track all this in a config like https://github.com/zeit/pkg#config. (Especially if we want our deps to be included in the final bundle as well)

[wtgtybhertgeghgtwtg]

Wouldn't that make it really impractical to work with create-react-app projects in monorepos and bring up some code duplication issues if an application uses libraries that react-scripts does?

[viankakrisna]

can you share more about the monorepos use case? I think the duplication does not matter because react-scripts should be self-contained and free of outside interference. Right now you can even modify webpack.config.dev.js from the outside and call scripts/build.js. This is what i did in my project:

// build.js, call node build.js instead of react-scripts build
process.env.NODE_ENV = 'production';
const config = require('react-scripts/config/webpack.config.prod');
const RollbarSourceMapPlugin = require('rollbar-sourcemap-webpack-plugin');
config.plugins.push(
  new RollbarSourceMapPlugin({
    accessToken: process.env.REACT_APP_ROLLBAR_SOURCEMAP_ID,
    version: process.env.REACT_APP_GIT_SHA,
    publicPath: config.output.publicPath,
  }),
);
require('react-scripts/scripts/build');

This breaks the guarantee of upgradable react-scripts but a convenient way to have an "almost standard" setup. Packaging react-scripts would break this use case and even react-app-rewired, but make it more resilient to outside interference.

So yeah, packaging would be an extreme decision to make. 😄 Is there any other way to make the react-scripts always work in the jungle of different environments and interference?