Reduce installed size in 2.x

[gaearon]

I noticed 2.x has regressed on the installed size

Before:

• 109,142,603 bytes (172.7 MB on disk) for 23,707 items

After:

• 135,452,954 bytes (216.4 MB on disk) for 29,913 items

You can check by creating a project with 2.0 alpha: #3815.

@wtgtybhertgeghgtwtg Is this something you could look into?

[wtgtybhertgeghgtwtg]

As far as new dependencies go:

• svgr adds 13 MB of unique dependencies, in part because it pins a version of jsdom that falls outside of the one jest uses.
• uglifyjs-webpack-plugin adds 5 MB of unique dependencies. Part of this is because it uses cacache, which brings in a lot of new and undeduped packages, but mostly it's just because it uses a new version of uglify that isn't used by handlebars or webpack. webpack switches to the new version in webpack@4.

As far as updates:

• jest grew a bit since jest@22, and the babel stuff in jest-runtime doesn't dedupe so well with babel-@7. I don't have numbers on the delta there.

[iansu]

It's unfortunate that svgr is so large. It may or may not stay in 2.0 though.

It would be really nice to have some kind of build size and install size check that ran automatically along with the other tests. Something like: https://github.com/apps/buildsize

[gaearon]

Cold or warm build? First build will be slower because we compile node_modules now (people overwhelmingly want that). But warm builds should not be much slower (since that data would be cached).

[gregberge]

@iansu I plan to update JSDOM soon, issue is already opened smooth-code/h2x#8

[gregberge]

Done, you can upgrade to v1.9.2, it uses the last version of JSDOM and the version is not fixed. So it should solve your problem.

[iansu]

@neoziro That's great! Thank you. I'll make a PR to update this right away.

[bugzpodder]

I took a quick look and svgr and jest 22/23 seem to be the biggest culprit as they contribute ~15MB of unique dependencies in the latest build (probably thanks to jsdom)
since we control babel-plugin-named-asset-import it might be possible to put svgr as an optional dependency like we do for sass?
Also, the largest contributor is actually rxjs (19MB), and we only include it to show a user prompt via inquirer pacakge. I think we can probably find an alternative there.

[bugzpodder]

I think we can downgrade inquirer to 3.3.0 as it doesn't have rxjs dependency.

[gregberge]

I hope svgr is now sharing the same JSDOM as Jest.

[bugzpodder]

Yep:
=> Found "jsdom@11.11.0"
info Reasons this module exists

• "svgr#h2x-core#h2x-parse" depends on it
• Hoisted from "svgr#h2x-core#h2x-parse#jsdom"
• Hoisted from "jest#jest-cli#jest-environment-jsdom#jsdom"
  jsdom has a dependency on nwsapi which is like 16MB.

[bugzpodder]

svgr also has a dependency on prettier @neoziro
https://github.com/smooth-code/svgr/blob/master/package.json#L51
I guess most people installs that nowadays, but shouldn't it be a devdependency?