Skip to content

[Bug] Unsafe Variable when running in a flutter desktop app #1591

Open
@ableflyer

Description

@ableflyer

[REQUIRED] Please fill in the following fields:

  • Pre-built SDK from the website or open-source from this repo: Pre-built SDK
  • Firebase C++ SDK version: 12.0.0
  • Problematic Firebase Component: Auth
  • Other Firebase Components in use: Auth, FireStore
  • Platform you are using the C++ SDK on: Windows desktop
  • Platform you are targeting: Windows, MacOS

[REQUIRED] Please describe the issue here:

When I use Firebase on Flutter desktop, it would give me this error

C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(801,7): error C2220: the following warning is treated as an error [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(801,7): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(827,7): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(801,7): error C2220: the following warning is treated as an error [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(801,7): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\extracted\firebase_cpp_sdk_windows\include\firebase/variant.h(827,7): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\ammar\AndroidStudioProjects\placementweekprogram\build\windows\plugins\firebase_auth\firebase_auth_plugin.vcxproj] Exception: Build process failed.

Steps to reproduce:

  1. set up a firebase project, make sure it includes windows
  2. install flutterfire cli and put the following commands
    firebase login
    dart pub global activate flutterfire_cli
    flutterfire configure --project=[insert a firebase protect name here]
  3. add firebase_core to pubspec.yaml
  4. run the app using flutter run

Relevant Code:

'main.dart' file:
`import 'package:flutter/material.dart';

void main() {
runApp(const MyApp());
}

class MyApp extends StatelessWidget {
const MyApp({super.key});

// This widget is the root of your application.
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
// This is the theme of your application.
//
// TRY THIS: Try running your application with "flutter run". You'll see
// the application has a blue toolbar. Then, without quitting the app,
// try changing the seedColor in the colorScheme below to Colors.green
// and then invoke "hot reload" (save your changes or press the "hot
// reload" button in a Flutter-supported IDE, or press "r" if you used
// the command line to start the app).
//
// Notice that the counter didn't reset back to zero; the application
// state is not lost during the reload. To reset the state, use hot
// restart instead.
//
// This works for code too, not just values: Most code changes can be
// tested with just a hot reload.
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}

class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});

// This widget is the home page of your application. It is stateful, meaning
// that it has a State object (defined below) that contains fields that affect
// how it looks.

// This class is the configuration for the state. It holds the values (in this
// case the title) provided by the parent (in this case the App widget) and
// used by the build method of the State. Fields in a Widget subclass are
// always marked "final".

final String title;

@OverRide
State createState() => _MyHomePageState();
}

class _MyHomePageState extends State {
int _counter = 0;

void _incrementCounter() {
setState(() {
// This call to setState tells the Flutter framework that something has
// changed in this State, which causes it to rerun the build method below
// so that the display can reflect the updated values. If we changed
// _counter without calling setState(), then the build method would not be
// called again, and so nothing would appear to happen.
_counter++;
});
}

@OverRide
Widget build(BuildContext context) {
// This method is rerun every time setState is called, for instance as done
// by the _incrementCounter method above.
//
// The Flutter framework has been optimized to make rerunning build methods
// fast, so that you can just rebuild anything that needs updating rather
// than having to individually change instances of widgets.
return Scaffold(
appBar: AppBar(
// TRY THIS: Try changing the color here to a specific color (to
// Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
// change color while the other colors stay the same.
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
// Here we take the value from the MyHomePage object that was created by
// the App.build method, and use it to set our appbar title.
title: Text(widget.title),
),
body: Center(
// Center is a layout widget. It takes a single child and positions it
// in the middle of the parent.
child: Column(
// Column is also a layout widget. It takes a list of children and
// arranges them vertically. By default, it sizes itself to fit its
// children horizontally, and tries to be as tall as its parent.
//
// Column has various properties to control how it sizes itself and
// how it positions its children. Here we use mainAxisAlignment to
// center the children vertically; the main axis here is the vertical
// axis because Columns are vertical (the cross axis would be
// horizontal).
//
// TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
// action in the IDE, or press "p" in the console), to see the
// wireframe for each widget.
mainAxisAlignment: MainAxisAlignment.center,
children: [
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: const Icon(Icons.add),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
`

flutter doctor
`
[√] Flutter (Channel stable, 3.13.1, on Microsoft Windows [Version 10.0.22631.3447], locale en-AE)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.2.4)
[!] Android Studio (version 2022.2)
X Unable to find bundled Java version.
[√] Android Studio (version 2023.1)
[√] VS Code (version 1.89.0)
[√] Connected device (3 available)
[√] Network resources

`

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions