Skip to content

Exempt from go/allstar check #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Exempt from go/allstar check #1173

merged 1 commit into from
Dec 19, 2022

Conversation

chkuang-g
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Exempt from go/allstar check #1171 because the binary file is part of the onboarding tool.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

N/A


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@chkuang-g chkuang-g requested a review from a-maurice December 17, 2022 00:13
@chkuang-g chkuang-g added the skip-release-notes Skip release notes check label Dec 17, 2022
@chkuang-g chkuang-g merged commit 3c64b33 into main Dec 19, 2022
@chkuang-g chkuang-g deleted the patch/allstar branch December 19, 2022 18:51
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 19, 2022
@github-actions
Copy link

github-actions bot commented Dec 19, 2022

❌  Integration test FAILED

Requested by @chkuang-g on commit 3c64b33
Last updated: Mon Dec 19 13:30 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FAILURE] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(2 failed tests)  FirebaseGmaTest.TestInterstitialAdStress
  FirebaseGmaTest.TestRewardedAdStress
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 19, 2022
@firebase firebase locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants