Skip to content

Make OAuth client_id optional in the google-services-desktop.json conversion script. #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2023
Merged

Make OAuth client_id optional in the google-services-desktop.json conversion script. #1223

merged 7 commits into from
Mar 6, 2023

Conversation

jacksonic
Copy link
Contributor

@jacksonic jacksonic commented Feb 24, 2023 •
edited
Loading

Description

This change allows the generate_xml_from_google_services_json.py to succeed at generating the output when the OAuth "CLIENT_ID" is missing from the input. The OAuth client for an app is not always present, and not needed in most cases.

Testing

Tested through local runs and the manually triggered integration tests.

Type of Change

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jacksonic jacksonic marked this pull request as draft February 24, 2023 16:14
@jacksonic jacksonic marked this pull request as ready for review February 28, 2023 18:11
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit refs/pull/1223/merge
Last updated: Thu Mar 2 10:59 PST 2023
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAdAnchorAdaptiveAd
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestAdViewLoadAd
  FirebaseGmaTest.TestAdViewLoadAdDestroyNotCalled
messaging [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 28, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 1, 2023
@jacksonic jacksonic marked this pull request as draft March 1, 2023 15:58
@jacksonic
Copy link
Contributor Author

Adjusting to retain the client_id when present.

@jacksonic jacksonic marked this pull request as ready for review March 1, 2023 19:53
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded. labels Mar 1, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 2, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 2, 2023
@DellaBitta
Copy link
Contributor

Integration test run - PASSED

@jacksonic jacksonic changed the title Remove OAuth client_id dependencies Fix config generation script to handle missing OAuth client_id Mar 2, 2023
@jacksonic jacksonic changed the title Fix config generation script to handle missing OAuth client_id Fix config generation script to allow missing OAuth client_id Mar 2, 2023
@jacksonic jacksonic changed the title Fix config generation script to allow missing OAuth client_id Make OAuth client_id optional in the google-services-desktop.json conversion script. Mar 2, 2023
@DellaBitta DellaBitta removed the tests: failed This PR's integration tests failed. label Mar 2, 2023
@DellaBitta DellaBitta merged commit fc9bbbf into firebase:main Mar 6, 2023
DellaBitta added a commit that referenced this pull request Mar 7, 2023
@DellaBitta
update generate_xml exectuable after change in PR #1223
67e74e9
@DellaBitta DellaBitta mentioned this pull request Mar 7, 2023
Merged
3 tasks
DellaBitta added a commit that referenced this pull request Mar 7, 2023
@DellaBitta
Update generate_xml exectuable after change in PR #1223 (#1233)
e774aff 
Updated the `executable for generate_xml_from_google_services.exe` after a change was made to the python version in #1223.
@firebase firebase locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacksonic @DellaBitta @a-maurice