Skip to content

Add App Check support to desktop Functions #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2023
Merged

Add App Check support to desktop Functions #1225

merged 4 commits into from
Mar 2, 2023

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add logic to include the App Check token to Functions calls on the desktop implementation. Adds Functions to the integration testapp.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Local testing

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Mar 1, 2023
@a-maurice a-maurice requested a review from AlmostMatt March 1, 2023 02:32
@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Mar 1, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited
Loading

⏳  Integration test in progress...

Requested by @a-maurice on commit 02b1777
Last updated: Thu Mar 2 14:31 PST 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 1, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 1, 2023
AlmostMatt
AlmostMatt approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question about one file.

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 2, 2023
@a-maurice a-maurice removed the tests: failed This PR's integration tests failed. label Mar 2, 2023
@a-maurice a-maurice merged commit 02b1777 into main Mar 2, 2023
@a-maurice a-maurice deleted the am-app_check_functions branch March 2, 2023 22:31
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Mar 2, 2023
@firebase firebase locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @AlmostMatt