Skip to content

Add flaky test handling for Storage test #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Conversation

jonsimantov
Copy link
Contributor

Add retry logic via RunFlakyBlock to TestPutFileAndGetFile.

@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@jonsimantov jonsimantov requested a review from DellaBitta July 13, 2021 17:51
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 13, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 13, 2021
@github-actions
Copy link

github-actions bot commented Jul 13, 2021

✅  Integration test succeeded!

Requested by @jonsimantov on commit d794b46
Last updated: Tue Jul 13 17:52 PDT 2021
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 13, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 13, 2021
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jul 13, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 13, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 13, 2021
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Jul 13, 2021
@jonsimantov
Copy link
Contributor Author

Merging - will fix additional Storage flakes in a subsequent PR.

@jonsimantov jonsimantov enabled auto-merge (squash) July 13, 2021 22:33
@jonsimantov jonsimantov merged commit d794b46 into main Jul 13, 2021
@jonsimantov jonsimantov deleted the bugfix/flaky-test-3 branch July 13, 2021 22:34
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels Jul 13, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2021
@firebase firebase locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants