Feature/enable tvos packaging #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimanyu
added
the
tests-requested: full
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @vimanyu on commit 27f3bc7
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
|
Tested by manually running CPP packaging workflow which in turn triggered integration tests against packaged sdk. |
vimanyu
added
tests-requested: quick
vimanyu
requested review from
jonsimantov and
sunmou99
and removed request for
jonsimantov
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
sunmou99
reviewed
Jul 23, 2021
| tar -czhf ../firebase-cpp-sdk-ios-package.tgz . | ||
| python sdk-src/scripts/gha/build_ios_tvos.py -b firebase-cpp-sdk-ios-tvos-build -s sdk-src | ||
| sdk-src/build_scripts/ios/package.sh firebase-cpp-sdk-ios-tvos-build firebase-cpp-sdk-ios-tvos-package | ||
| sdk-src/build_scripts/tvos/package.sh firebase-cpp-sdk-ios-tvos-build firebase-cpp-sdk-ios-tvos-package |
There was a problem hiding this comment.
It may worth combining these two packaging steps as a follow up.
sunmou99
reviewed
Jul 23, 2021
| @@ -558,17 +558,18 @@ def main(): | |||
|
|
|||
| # Since we renamed firebase_app.framework to firebase.framework we add that | |||
| # to our list of targets. | |||
| supported_targets.add('firebase') | |||
| targets = set(args.target) | |||
| targets.add('firebase') | |||
jonsimantov
approved these changes
Jul 23, 2021
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable building tvos libraries in nightly packaging builds and support for tvos in integration tests against packaged sdk.