Skip to content

Fixed issue where storage wasn't passing cookies when using firebase Studio #9111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

maneesht
Copy link
Contributor

Fixed CORS issue when using Storage with Firebase Studio

Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 0baef5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@firebase/storage Patch
@firebase/util Patch
firebase Patch
@firebase/storage-compat Patch
@firebase/ai Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/data-connect Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maneesht maneesht marked this pull request as ready for review June 20, 2025 16:40
@maneesht maneesht requested review from a team and tonyjhuang as code owners June 20, 2025 16:41
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 20, 2025

Size Report 1

Affected Products

  • @firebase/util

    TypeBase (b97eab3)Merge (6bb81b9)Diff
    browser29.3 kB29.4 kB+118 B (+0.4%)
    main35.7 kB35.8 kB+118 B (+0.3%)
    module29.3 kB29.4 kB+118 B (+0.4%)
  • bundle

    39 size changes

    TypeBase (b97eab3)Merge (6bb81b9)Diff
    auth (Anonymous)77.9 kB78.0 kB+107 B (+0.1%)
    auth (EmailAndPassword)88.0 kB88.1 kB+107 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)109 kB109 kB+107 B (+0.1%)
    auth (GooglePopup)102 kB102 kB+107 B (+0.1%)
    auth (GoogleRedirect)102 kB102 kB+107 B (+0.1%)
    auth (Phone)95.4 kB95.5 kB+107 B (+0.1%)
    database (Append to a list of data)154 kB154 kB+107 B (+0.1%)
    database (Filtering data)153 kB153 kB+107 B (+0.1%)
    database (Listen for child events)170 kB170 kB+107 B (+0.1%)
    database (Listen for value events + Detach listeners)170 kB170 kB+107 B (+0.1%)
    database (Listen for value events)170 kB170 kB+107 B (+0.1%)
    database (Read data once)169 kB169 kB+107 B (+0.1%)
    database (Save data as transactions)172 kB172 kB+107 B (+0.1%)
    database (Sort data)155 kB155 kB+107 B (+0.1%)
    database (Write data)154 kB154 kB+107 B (+0.1%)
    firestore (CSI Auto Indexing Disable and Delete)280 kB280 kB+107 B (+0.0%)
    firestore (CSI Auto Indexing Enable)280 kB280 kB+107 B (+0.0%)
    firestore (Persistence)311 kB311 kB+107 B (+0.0%)
    firestore (Query Cursors)256 kB256 kB+107 B (+0.0%)
    firestore (Query)254 kB254 kB+107 B (+0.0%)
    firestore (Read data once)242 kB242 kB+107 B (+0.0%)
    firestore (Read Write w Persistence)336 kB336 kB+107 B (+0.0%)
    firestore (Realtime updates)244 kB244 kB+107 B (+0.0%)
    firestore (Transaction)221 kB221 kB+107 B (+0.0%)
    firestore (Write data)220 kB221 kB+107 B (+0.0%)
    firestore-lite (Query Cursors)109 kB109 kB+107 B (+0.1%)
    firestore-lite (Query)105 kB105 kB+107 B (+0.1%)
    firestore-lite (Read data once)80.6 kB80.7 kB+107 B (+0.1%)
    firestore-lite (Transaction)106 kB106 kB+107 B (+0.1%)
    firestore-lite (Write data)90.2 kB90.3 kB+107 B (+0.1%)
    functions (call)39.4 kB39.5 kB+107 B (+0.3%)
    storage (getBytes)47.2 kB47.3 kB+107 B (+0.2%)
    storage (getDownloadURL)49.2 kB49.4 kB+107 B (+0.2%)
    storage (getMetadata)48.7 kB48.8 kB+107 B (+0.2%)
    storage (list + listAll)48.1 kB48.2 kB+107 B (+0.2%)
    storage (updateMetadata)49.0 kB49.1 kB+107 B (+0.2%)
    storage (uploadBytes)53.8 kB53.9 kB+107 B (+0.2%)
    storage (uploadBytesResumable)63.8 kB63.9 kB+107 B (+0.2%)
    storage (uploadString)54.0 kB54.1 kB+107 B (+0.2%)

  • firebase

    15 size changes

    TypeBase (b97eab3)Merge (6bb81b9)Diff
    firebase-auth-compat.js145 kB146 kB+86 B (+0.1%)
    firebase-auth-cordova.js143 kB143 kB+94 B (+0.1%)
    firebase-auth-web-extension.js125 kB125 kB+94 B (+0.1%)
    firebase-auth.js163 kB163 kB+94 B (+0.1%)
    firebase-compat.js802 kB802 kB+94 B (+0.0%)
    firebase-data-connect.js22.7 kB22.8 kB+94 B (+0.4%)
    firebase-database-compat.js168 kB168 kB+94 B (+0.1%)
    firebase-database.js192 kB192 kB+94 B (+0.0%)
    firebase-firestore-compat.js347 kB347 kB+94 B (+0.0%)
    firebase-firestore-lite.js137 kB137 kB+94 B (+0.1%)
    firebase-firestore.js449 kB449 kB+94 B (+0.0%)
    firebase-functions-compat.js14.7 kB14.8 kB+94 B (+0.6%)
    firebase-functions.js19.5 kB19.6 kB+94 B (+0.5%)
    firebase-storage-compat.js44.2 kB44.3 kB+94 B (+0.2%)
    firebase-storage.js51.1 kB51.2 kB+94 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mR27nK8qoI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 20, 2025

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.8 kB62.9 kB+107 B (+0.2%)
    • ActionCodeURL

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.8 kB64.0 kB+107 B (+0.2%)
    • AuthCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.8 kB62.9 kB+107 B (+0.2%)
    • AuthErrorCodes

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps67.7 kB67.8 kB+107 B (+0.2%)
    • EmailAuthCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps70.4 kB70.5 kB+107 B (+0.2%)
    • EmailAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps72.0 kB72.2 kB+107 B (+0.1%)
    • FacebookAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps67.6 kB67.7 kB+107 B (+0.2%)
    • FactorId

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • GithubAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps67.6 kB67.7 kB+107 B (+0.2%)
    • GoogleAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps67.6 kB67.7 kB+107 B (+0.2%)
    • OAuthCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.7 kB64.8 kB+107 B (+0.2%)
    • OAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps68.5 kB68.6 kB+107 B (+0.2%)
    • OperationType

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • PhoneAuthCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.7 kB64.8 kB+107 B (+0.2%)
    • PhoneAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps74.0 kB74.1 kB+107 B (+0.1%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.4 kB63.5 kB+107 B (+0.2%)
    • ProviderId

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.8 kB+107 B (+0.2%)
    • RecaptchaVerifier

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps69.5 kB69.6 kB+107 B (+0.2%)
    • SAMLAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps68.9 kB69.0 kB+107 B (+0.2%)
    • SignInMethod

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.7 kB62.8 kB+107 B (+0.2%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps65.1 kB65.2 kB+107 B (+0.2%)
    • TotpSecret

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.5 kB63.6 kB+107 B (+0.2%)
    • TwitterAuthProvider

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps67.6 kB67.7 kB+107 B (+0.2%)
    • applyActionCode

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.8 kB+107 B (+0.2%)
    • beforeAuthStateChanged

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • browserCookiePersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.5 kB64.6 kB+107 B (+0.2%)
    • browserLocalPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps65.6 kB65.7 kB+107 B (+0.2%)
    • browserPopupRedirectResolver

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps87.3 kB87.4 kB+107 B (+0.1%)
    • browserSessionPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps65.6 kB65.7 kB+107 B (+0.2%)
    • checkActionCode

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.8 kB63.9 kB+107 B (+0.2%)
    • confirmPasswordReset

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.9 kB63.0 kB+107 B (+0.2%)
    • connectAuthEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps69.2 kB69.3 kB+107 B (+0.2%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps69.5 kB69.6 kB+107 B (+0.2%)
    • debugErrorMap

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps75.0 kB75.1 kB+107 B (+0.1%)
    • deleteUser

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.9 kB63.0 kB+107 B (+0.2%)
    • getAdditionalUserInfo

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.9 kB64.0 kB+107 B (+0.2%)
    • getAuth

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps109 kB109 kB+107 B (+0.1%)
    • getIdToken

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • getIdTokenResult

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.5 kB62.6 kB+107 B (+0.2%)
    • getMultiFactorResolver

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps65.4 kB65.5 kB+107 B (+0.2%)
    • getRedirectResult

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps70.2 kB70.3 kB+107 B (+0.2%)
    • inMemoryPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.5 kB62.6 kB+107 B (+0.2%)
    • indexedDBLocalPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps70.0 kB70.1 kB+107 B (+0.2%)
    • initializeAuth

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.3 kB63.4 kB+107 B (+0.2%)
    • initializeRecaptchaConfig

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps66.3 kB66.4 kB+107 B (+0.2%)
    • isSignInWithEmailLink

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.0 kB64.1 kB+107 B (+0.2%)
    • linkWithCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.6 kB63.7 kB+107 B (+0.2%)
    • linkWithPhoneNumber

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps74.8 kB74.9 kB+107 B (+0.1%)
    • linkWithPopup

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps73.8 kB73.9 kB+107 B (+0.1%)
    • linkWithRedirect

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps68.9 kB69.0 kB+107 B (+0.2%)
    • multiFactor

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.8 kB64.9 kB+107 B (+0.2%)
    • onAuthStateChanged

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • onIdTokenChanged

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • parseActionCodeURL

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.9 kB64.0 kB+107 B (+0.2%)
    • prodErrorMap

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.5 kB62.6 kB+107 B (+0.2%)
    • reauthenticateWithCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.2 kB64.3 kB+107 B (+0.2%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps75.4 kB75.5 kB+107 B (+0.1%)
    • reauthenticateWithPopup

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps73.9 kB74.0 kB+107 B (+0.1%)
    • reauthenticateWithRedirect

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps68.7 kB68.8 kB+107 B (+0.2%)
    • reload

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.5 kB62.6 kB+107 B (+0.2%)
    • revokeAccessToken

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • sendEmailVerification

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.6 kB63.7 kB+107 B (+0.2%)
    • sendPasswordResetEmail

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps69.2 kB69.3 kB+107 B (+0.2%)
    • sendSignInLinkToEmail

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps69.3 kB69.4 kB+107 B (+0.2%)
    • setPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • signInAnonymously

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.7 kB63.8 kB+107 B (+0.2%)
    • signInWithCredential

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps64.0 kB64.1 kB+107 B (+0.2%)
    • signInWithCustomToken

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.6 kB63.7 kB+107 B (+0.2%)
    • signInWithEmailAndPassword

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps73.8 kB73.9 kB+107 B (+0.1%)
    • signInWithEmailLink

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps73.8 kB73.9 kB+107 B (+0.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps75.2 kB75.3 kB+107 B (+0.1%)
    • signInWithPopup

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps73.8 kB73.9 kB+107 B (+0.1%)
    • signInWithRedirect

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps68.4 kB68.5 kB+107 B (+0.2%)
    • signOut

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • unlink

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.1 kB63.2 kB+107 B (+0.2%)
    • updateCurrentUser

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • updateEmail

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.9 kB63.0 kB+107 B (+0.2%)
    • updatePassword

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.8 kB63.0 kB+107 B (+0.2%)
    • updatePhoneNumber

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.4 kB63.5 kB+107 B (+0.2%)
    • updateProfile

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.0 kB63.1 kB+107 B (+0.2%)
    • useDeviceLanguage

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • validatePassword

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps62.6 kB62.7 kB+107 B (+0.2%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.6 kB63.7 kB+107 B (+0.2%)
    • verifyPasswordResetCode

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps63.8 kB64.0 kB+107 B (+0.2%)
  • @firebase/data-connect

    • CallerSdkTypeEnum

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • Code

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps30.9 kB31.1 kB+107 B (+0.3%)
    • DataConnect

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • DataConnectError

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • DataConnectOperationError

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • MUTATION_STR

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • MutationManager

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • QUERY_STR

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • SOURCE_CACHE

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • SOURCE_SERVER

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • areTransportOptionsEqual

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • connectDataConnectEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps35.5 kB35.6 kB+107 B (+0.3%)
    • executeMutation

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • executeQuery

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • getDataConnect

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps38.8 kB38.9 kB+107 B (+0.3%)
    • mutationRef

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.1 kB31.2 kB+107 B (+0.3%)
    • parseOptions

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • queryRef

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.1 kB31.2 kB+107 B (+0.3%)
    • setLogLevel

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • subscribe

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps39.3 kB39.4 kB+107 B (+0.3%)
    • terminate

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.0 kB31.1 kB+107 B (+0.3%)
    • toQueryRef

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps39.0 kB39.1 kB+107 B (+0.3%)
    • validateArgs

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps38.9 kB39.0 kB+107 B (+0.3%)
    • validateDCOptions

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps31.2 kB31.3 kB+107 B (+0.3%)
  • @firebase/database

    • connectDatabaseEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps145 kB145 kB+107 B (+0.1%)
    • getDatabase

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps152 kB152 kB+107 B (+0.1%)
  • @firebase/firestore

    • addDoc

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps207 kB207 kB+107 B (+0.1%)
    • connectFirestoreEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps93.3 kB93.4 kB+107 B (+0.1%)
    • deleteDoc

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps197 kB197 kB+107 B (+0.1%)
    • disableNetwork

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps185 kB185 kB+107 B (+0.1%)
    • enableIndexedDbPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps262 kB262 kB+107 B (+0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps298 kB298 kB+107 B (+0.0%)
    • enableNetwork

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps185 kB185 kB+107 B (+0.1%)
    • executeWrite

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps196 kB196 kB+107 B (+0.1%)
    • getAggregateFromServer

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps193 kB193 kB+107 B (+0.1%)
    • getCountFromServer

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps193 kB193 kB+107 B (+0.1%)
    • getDoc

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps228 kB228 kB+107 B (+0.0%)
    • getDocFromServer

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps228 kB228 kB+107 B (+0.0%)
    • getDocs

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps229 kB229 kB+107 B (+0.0%)
    • getDocsFromServer

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps229 kB229 kB+107 B (+0.0%)
    • getFirestore

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps101 kB101 kB+107 B (+0.1%)
    • initializeFirestore

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps87.4 kB87.5 kB+107 B (+0.1%)
    • loadBundle

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps195 kB195 kB+107 B (+0.1%)
    • memoryLocalCache

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps179 kB179 kB+107 B (+0.1%)
    • onSnapshot

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps230 kB230 kB+107 B (+0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps219 kB219 kB+107 B (+0.0%)
    • persistentLocalCache

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps258 kB258 kB+107 B (+0.0%)
    • persistentMultipleTabManager

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps293 kB294 kB+107 B (+0.0%)
    • persistentSingleTabManager

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps257 kB257 kB+107 B (+0.0%)
    • runTransaction

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps207 kB207 kB+107 B (+0.1%)
    • setDoc

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps206 kB206 kB+107 B (+0.1%)
    • updateDoc

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps206 kB206 kB+107 B (+0.1%)
    • waitForPendingWrites

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps186 kB186 kB+107 B (+0.1%)
    • writeBatch

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps208 kB208 kB+107 B (+0.1%)
  • @firebase/functions

    • connectFunctionsEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps25.3 kB25.4 kB+107 B (+0.4%)
    • getFunctions

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps33.2 kB33.3 kB+107 B (+0.3%)
  • @firebase/storage

    • _UploadTask

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps49.4 kB49.5 kB+107 B (+0.2%)
    • connectStorageEmulator

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps34.8 kB34.9 kB+107 B (+0.3%)
    • deleteObject

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps32.9 kB33.0 kB+107 B (+0.3%)
    • getBlob

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps33.0 kB33.1 kB+107 B (+0.3%)
    • getBytes

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps33.0 kB33.1 kB+107 B (+0.3%)
    • getDownloadURL

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps35.1 kB35.2 kB+107 B (+0.3%)
    • getMetadata

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps34.6 kB34.7 kB+107 B (+0.3%)
    • getStorage

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps42.7 kB42.8 kB+107 B (+0.3%)
    • list

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps33.7 kB33.8 kB+107 B (+0.3%)
    • listAll

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps33.9 kB34.0 kB+107 B (+0.3%)
    • updateMetadata

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps34.8 kB34.9 kB+107 B (+0.3%)
    • uploadBytes

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps39.7 kB39.8 kB+107 B (+0.3%)
    • uploadBytesResumable

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps49.6 kB49.7 kB+107 B (+0.2%)
    • uploadString

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size-with-ext-deps39.9 kB40.0 kB+107 B (+0.3%)
  • @firebase/util

    • isCloudWorkstation

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size90 B197 B+107 B (+118.9%)
      size-with-ext-deps90 B197 B+107 B (+118.9%)
    • updateEmulatorBanner

      Size

      TypeBase (b97eab3)Merge (6bb81b9)Diff
      size4.42 kB4.53 kB+107 B (+2.4%)
      size-with-ext-deps4.42 kB4.53 kB+107 B (+2.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MjZkim7RwD.html

Copy link

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on implementation details, but this seems like it fixes the issue!

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants