Skip to content

refactor(js/plugins/vertexai): refactored tests for dynamic models #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

refactor(js/plugins/vertexai): refactored tests for dynamic models #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773bc86
refactor(js/plugins/vertexai): refactored tests for dynamic models
Apr 28, 2025
b93d5ca
refactor(js/plugins/googleai) fix formatting
Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions js/plugins/googleai/tests/gemini_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,25 @@ describe('plugin', () => {
assert.strictEqual(flash.__action.name, 'googleai/gemini-1.5-flash');
});

it('references both pre-registered or dynamic models', async () => {
it('references dynamic models', async () => {
const ai = genkit({
plugins: [googleAI({})],
});
const giraffeRef = gemini('gemini-4.5-giraffe');
assert.strictEqual(giraffeRef.name, 'googleai/gemini-4.5-giraffe');
const giraffe = await ai.registry.lookupAction(
`/model/${giraffeRef.name}`
);
assert.ok(giraffe);
assert.strictEqual(giraffe.__action.name, 'googleai/gemini-4.5-giraffe');
assertEqualModelInfo(
giraffe.__action.metadata?.model,
'Google AI - gemini-4.5-giraffe',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);
});

it('references pre-registered models', async () => {
const flash002Ref = gemini('gemini-1.5-flash-002');
const ai = genkit({
plugins: [
Expand Down Expand Up @@ -524,20 +542,6 @@ describe('plugin', () => {
'Google AI - gemini-4.0-banana',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);

// this one is dynamically resolved (not pre-registered)
const giraffeRef = gemini('gemini-4.5-giraffe');
assert.strictEqual(giraffeRef.name, 'googleai/gemini-4.5-giraffe');
const giraffe = await ai.registry.lookupAction(
`/model/${giraffeRef.name}`
);
assert.ok(giraffe);
assert.strictEqual(giraffe.__action.name, 'googleai/gemini-4.5-giraffe');
assertEqualModelInfo(
giraffe.__action.metadata?.model,
'Google AI - gemini-4.5-giraffe',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);
});
});
});
Expand Down
30 changes: 17 additions & 13 deletions js/plugins/vertexai/tests/plugin_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,23 @@ describe('plugin', () => {
assert.strictEqual(flash.__action.name, 'vertexai/gemini-1.5-flash');
});

it('references both pre-registered or dynamic models', async () => {
it('references dynamic models', async () => {
const ai = genkit({
plugins: [vertexAI({ location: 'us-central1' })],
});
const giraffeRef = gemini('gemini-4.5-giraffe');
assert.strictEqual(giraffeRef.name, 'vertexai/gemini-4.5-giraffe');
const giraffe = await ai.registry.lookupAction(`/model/${giraffeRef.name}`);
assert.ok(giraffe);
assert.strictEqual(giraffe.__action.name, 'vertexai/gemini-4.5-giraffe');
assertEqualModelInfo(
giraffe.__action.metadata?.model,
'Vertex AI - gemini-4.5-giraffe',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);
});

it('references pre-registered models', async () => {
const flash002Ref = gemini('gemini-1.5-flash-002');
const ai = genkit({
plugins: [
Expand Down Expand Up @@ -121,18 +137,6 @@ describe('plugin', () => {
'Vertex AI - gemini-4.0-banana',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);

// this one is dynamically resolved (not pre-registered)
const giraffeRef = gemini('gemini-4.5-giraffe');
assert.strictEqual(giraffeRef.name, 'vertexai/gemini-4.5-giraffe');
const giraffe = await ai.registry.lookupAction(`/model/${giraffeRef.name}`);
assert.ok(giraffe);
assert.strictEqual(giraffe.__action.name, 'vertexai/gemini-4.5-giraffe');
assertEqualModelInfo(
giraffe.__action.metadata?.model,
'Vertex AI - gemini-4.5-giraffe',
GENERIC_GEMINI_MODEL.info! // <---- generic model fallback
);
});
});

Expand Down