Skip to content

fix(js/plugins/googleai): fixed systemRole support for dynamic models #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix(js/plugins/googleai): fixed systemRole support for dynamic models #3018

merged 1 commit into from
Jun 3, 2025

Conversation

ifielker
Copy link
Collaborator

@ifielker ifielker commented Jun 3, 2025 •
edited
Loading

Fix for #3017

Checklist (if applicable):

@ifielker ifielker requested a review from mbleigh June 3, 2025 00:13
@ifielker ifielker linked an issue Jun 3, 2025 that may be closed by this pull request
[JS] googleai/vertexai should default to max model capability support #3017
Closed
@ifielker ifielker requested a review from pavelgj June 3, 2025 00:19
@ifielker ifielker merged commit ffe2c07 into main Jun 3, 2025
5 checks passed
@ifielker ifielker deleted the if-fixSystem branch June 3, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbleigh mbleigh mbleigh approved these changes

@pavelgj pavelgj Awaiting requested review from pavelgj

Assignees
No one assigned
Labels
fix js
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] googleai/vertexai should default to max model capability support
2 participants
@ifielker @mbleigh