-
Notifications
You must be signed in to change notification settings - Fork 295
feat(js/plugins/googleai): added support for imagen and veo models to googleai plugin #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifielker
reviewed
Jun 10, 2025
Renames the `Operation` type and schema to `ModelOperation` to avoid naming conflicts with other potential `Operation` types within the codebase. This change improves clarity and prevents potential confusion.
Corrected "fianal" to "final" in the JSDoc comment for the `generateOperation` method.
Corrected a typo in the example code for the `generateOperation` method in the `GenkitBeta` class. The method name was incorrectly spelled as `generategenerateOperation`.
Simplify the check for message content existence by using optional chaining. This makes the code more concise and readable.
This commit renames the `ImagenInstance` interface to `VeoInstance` to align with the model name and improve code clarity. It also renames the `Operation` type to `ModelOperation` for better distinction.
Previously, the `finishReason` was always set to 'pending' for VEO model operations, even when the operation was complete. This commit updates the logic to set `finishReason` to 'stop' when the VEO operation's `done` property is true, accurately reflecting the state of the operation.
ifielker
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new operation API
Checklist (if applicable):