feat(py/genkit): added the resolve_method for openai compatible plugin #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJLazaro
reviewed
Jun 10, 2025
AbeJLazaro
reviewed
Jun 10, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
reviewed
Jun 11, 2025
AbeJLazaro
reviewed
Jun 11, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
reviewed
Jun 11, 2025
|
Let's check if it is required to keep using the handler. I think the model generate method is enough, and the handler is only a wrapper to determine which models are valid based on the supported models variable. We are going to deprecate those validations, so maybe the handler is not required. |
hendrixmar
force-pushed
the
hendrixmar/feature/add_resolve_action_openai_compat
branch
from
7792386 to
e0d8647
Compare
AbeJLazaro
approved these changes
Jun 13, 2025
pavelgj
reviewed
Jun 16, 2025
| metadata={ | ||
| 'model': { | ||
| 'label': f"OpenAI - {name}", | ||
| 'supports': {'multiturn': True} |
There was a problem hiding this comment.
you probably want to add other supports fields as well.. like system prompt?
There was a problem hiding this comment.
we saw that the initializate method only add the multiturn field in the metadata field. Should we change both methods to add all the supports object in the metadata?
There was a problem hiding this comment.
yes. A shared constant would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the concrete implementation of the resolve_method for the OpenAI compat plugin.