fix(js/plugins/google-cloud): Run all tests and refactor to only initialize telemetry once #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an 'it.only' in one of the tests. Removing it uncovered that the two describe blocks couldn't actually both run successfully because they were each enabling telemetry when this can only happen once. I rearranged the tests to make sure that we only initialize telemetry once, but this uncovered another problem, where only one of them was enabling JSON format for the logs, so I updated everything to use structured JSON format.
bryanatkinson
changed the title
schnecle
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Ah yeah, this is part of a refactor that I started a while ago to move away from the raw text log lines we output when we don't specify a json formatter to look at the actual json object. I think that' why we had the it.only because you don't really need those other ones. They aren't hurting anything but they are less comprehensive. This looks good!
hendrixmar
pushed a commit
that referenced
this pull request
Jun 20, 2025
…ialize telemetry once (#3076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an 'it.only' in one of the tests. Removing it uncovered that the two describe blocks couldn't actually both run successfully because they were each enabling telemetry when this can only happen once. I rearranged the tests to make sure that we only initialize telemetry once, but this uncovered another problem, where only one of them was enabling JSON format for the logs, so I updated everything to use structured JSON format.
Checklist (if applicable):