-
Notifications
You must be signed in to change notification settings - Fork 515
Partly solves Issue #39 (Extended Configuration Proposal) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… predefined constants
… predefined constants
I wonder if it's better to name this ANALOG_CONFIG or something like that since all of the proposed options are currently analog-specific. My concern is that a 'catch all' config could quickly become too complex. I haven't put a lot of thought into how many settings will need to be supported with more capable boards such as the Due and other 32-bit hardware. Any ideas for additional configs that may be either necessary of at least nice-to-have in the near future? |
Lets revisit this now that Due support is on the table. |
This will also need to update the capability query response with the analog resolution. Currently it's hardcoded to 10. |
Lets rename this from CONFIG_EXT to ANALOG_CONFIG and work on getting it in. It needs to update the capability query to reflect the set analog resolution (currently hard coded to 10 bits). We may also need a way to query the reference voltage setting. |
case 0: // analogReference request | ||
switch (argv[1]) { | ||
case 0: | ||
analogReference(DEFAULT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need a way to query the set reference voltage
I looked into this further and there's an issue in which AVR boards don't include analogWriteResolution and analogReadResolution. Only SAM boards do. Also SAM boards do not support setting the analogReference. There is only one value for SAM boards AR_DEFAULT and it's a typedef rather than a define so there's no good way to ignore analogReference for SAM boards but allow it for AVRs. This would likely require adding some defines to Boards.h in order to sort out AVR vs SAM boards to determine what supports analog resolution and analog reference. |
Closing this and opening new request for analog-config mainly for discussion since there are a number of challenges in getting it to work. |
No description provided.