Skip to content

[wearable_rotary] Add wearable rotary plugin #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 1, 2021
Merged

[wearable_rotary] Add wearable rotary plugin #108

merged 11 commits into from
Jun 1, 2021

Conversation

nojinjeong
Copy link
Contributor

@nojinjeong nojinjeong commented May 21, 2021 •
edited
Loading

Plugin that allows listening to rotary(bezel) events on wearable devices.

To-Dos:

  • testing on Tizen devices
  • updating README in root
  • improving README in package
  • create example code
    considering implementing platform_interface for other wearable OS
    I think this should be done as separate pr.
    implementing integration test
    The rotary action is related to c++ code. So I decided to delete this work

@nojinjeong nojinjeong mentioned this pull request May 21, 2021
Closed
@nojinjeong nojinjeong marked this pull request as ready for review May 25, 2021 12:26
@nojinjeong nojinjeong requested a review from a team May 25, 2021 12:26
swift-kim
swift-kim reviewed May 25, 2021
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, please be careful when referring to other plugins code as some plugins are old and use outdated coding practices.

rwalczyna
rwalczyna reviewed May 25, 2021
View reviewed changes
bbrto21
bbrto21 reviewed May 26, 2021
View reviewed changes
@nojinjeong
Copy link
Contributor Author

@bbrto21 @swift-kim @rwalczyna Thanks for suggestions. I updated based on suggestions.

swift-kim
swift-kim reviewed May 26, 2021
View reviewed changes
swift-kim
swift-kim reviewed May 27, 2021
View reviewed changes
swift-kim
swift-kim reviewed May 27, 2021
View reviewed changes
swift-kim
swift-kim reviewed May 27, 2021
View reviewed changes
bbrto21
bbrto21 reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run example on TW3, it works nicely!

bbrto21
bbrto21 approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-kim swift-kim merged commit cbe2ec6 into flutter-tizen:master Jun 1, 2021
swift-kim pushed a commit that referenced this pull request Jun 1, 2021
@nojinjeong @swift-kim
[wearable_rotary] Add wearable rotary plugin (#108)
8704927 
* Add wearable rotary plugin

* Implement example code

* Fix some bugs

* Update README

* Update based on review

* Update based on review

* Update based on review

* Update based on review

* Update based on linter suggestions

* Update based on review

* Update based on review
@swift-kim
Copy link
Member

Force-pushed to fix a typo (hompage→homepage) before publishing.

@swift-kim swift-kim mentioned this pull request Jun 10, 2021
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalczyna rwalczyna rwalczyna left review comments

@bbrto21 bbrto21 bbrto21 approved these changes

@swift-kim swift-kim swift-kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nojinjeong @swift-kim @bbrto21 @rwalczyna