Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enabled hiding the home indicator with SystemChrome.setEnabledSystemUIOverlays #17574

Merged
merged 6 commits into from
Apr 9, 2020

Conversation

gaaclarke
Copy link
Member

relevant issue: flutter/flutter#20965

@auto-assign auto-assign bot requested a review from GaryQian April 7, 2020 22:02
@gaaclarke gaaclarke requested a review from xster April 7, 2020 22:02
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LG. Can we add a test? I think this will work in scenario. Mock dart sends a channel message, sets expectation on view controller.

@gaaclarke
Copy link
Member Author

Implementation LG. Can we add a test? I think this will work in scenario. Mock dart sends a channel message, sets expectation on view controller.

added a unit test

@gaaclarke gaaclarke requested a review from xster April 7, 2020 23:44
@xster
Copy link
Member

xster commented Apr 8, 2020

LGTM, thanks

@gaaclarke
Copy link
Member Author

Landing, Github says there are tasks pending, but if you click on the details they have succeeded.

@gaaclarke gaaclarke merged commit 1c6934e into flutter:master Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2020
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@joasag
Copy link

joasag commented Apr 16, 2020

Is this active on the latest flutter release? (1.18.0-dev.5.0) Or how do I make use of this? Having the same issue.

@gaaclarke
Copy link
Member Author

@jockebq it's available in 1.18.0-dev.5.0 and later.

@joasag
Copy link

joasag commented Apr 17, 2020

@gaaclarke I just tested it out, and it seems to work in landscape, but not in portrait. And I am having issues with filling the screen with the content on my flutter_webview_plugin.
bild
bild

@gaaclarke gaaclarke deleted the hide-home-indicator branch April 17, 2020 16:52
@gaaclarke
Copy link
Member Author

@jockebq if you think you've found a bug can you file a new bug please with reproduction steps and expected / versus observed results?

Heads up, iOS doesn't provide a definitive way to hide the home indicator. You can request it to hide and it will take that preference into consideration. See https://developer.apple.com/documentation/uikit/uiviewcontroller/2887510-prefershomeindicatorautohidden?language=objc for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants