Update third_party/{icu,boringssl} dependencies #19049
Conversation
This is the corresponding engine change, which was done for Dart in: * https://dart-review.googlesource.com/c/sdk/+/151220 * https://dart-review.googlesource.com/c/sdk/+/151221
|
It looks like there are some changes in ICU licenses which fail Flutter's licenses check. |
|
fyi @gw280 |
|
@zanderso Can we land this even though |
|
It looks like the Linux Drone might be dependent on the tree (luci-engine) being green. So, we'll have to wait for the tree to be green before landing. I'm following up with the engine sheriff, so hopefully this will clear up soon. |
|
The Linux Engine Drone builds look green to me on luci https://ci.chromium.org/p/flutter/builders/try/Linux%20Engine%20Drone/36491 Not sure why the PR isn't updating. @godofredoc @digiter any ideas? |
x drone should not be added as checks. Here is the context flutter/flutter#59526 |
|
Got it. So this is safe to land whenever luci-engine is green. |
Yes, it is safe to land it. |
|
Have created a new PR #19074 which resolves the conflicts. |
|
@a-siva Is it all right with you if I land this PR first? |
|
I saw you copied my changes from this PR into yours, so I'll close this one. |
This updates ICU and BoringSSL dependencies, which was already done in Dart, see:
Issue flutter/flutter#43968