This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Turn off failing XCTest attachment collection #19668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jul 13, 2020
jmagman
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Hm this didn't do what I'd hoped, I still see: |
jmagman
force-pushed
the
attachment-tests
branch
from
de387e9 to
32621cc
Compare
jmagman
commented
Jul 14, 2020
|
|
||
| if (golden.image) { | ||
| XCTAttachment* goldenAttachment = [XCTAttachment attachmentWithImage:golden.image]; | ||
| attachment.name = @"current_golden"; |
There was a problem hiding this comment.
I think this was a copy-paste bug and was intended to be goldenAttachment.name
jmagman
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2020
This was referenced Dec 15, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
Save a recording/screenshot to the uploaded xcresult when a Scenario test fails. <img width="1052" alt="Screenshot 2023-12-14 at 6 34 47�PM" src="https://github.com/flutter/engine/assets/682784/c1294497-28f6-4400-b21c-da689a224dc4"> <img width="244" alt="Screenshot 2023-12-14 at 6 41 03�PM" src="https://github.com/flutter/engine/assets/682784/f769dd5f-a71b-4320-b9ef-64eac722166a"> No more errant spew as reported in #19668 when this was originally turned off. ``` Test Case '-[StatusBarTest testTapStatusBar]' started. t = 0.00s Start Test at 2023-12-14 18:20:34.207 ... t = 2.69s Synthesize event t = 2.70s Find the StatusBar at {{0.0, 0.0}, {375.0, 20.0}} t = 2.72s Find the StatusBar at {{0.0, 0.0}, {375.0, 20.0}} t = 2.74s Find the StatusBar at {{0.0, 0.0}, {375.0, 20.0}} t = 3.03s Wait for com.apple.springboard to idle t = 3.43s Waiting 1.0s for "0,PointerChange.add,device=0,buttons=0,signalKind=PointerSignalKind.none" TextField to exist t = 4.43s Checking `Expect predicate `exists == 1` for object "0,PointerChange.add,device=0,buttons=0,signalKind=PointerSignalKind.none" TextField` t = 4.43s Checking existence of `"0,PointerChange.add,device=0,buttons=0,signalKind=PointerSignalKind.none" TextField` t = 4.45s Capturing element debug description t = 4.45s Checking existence of `"0,PointerChange.add,device=0,buttons=0,signalKind=PointerSignalKind.none" TextField` /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim/scenario_app/Scenarios/ScenariosUITests/StatusBarTest.m:37: error: -[StatusBarTest testTapStatusBar] : ((exists) is true) failed t = 4.48s Tear Down ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761683198070320113/+/u/test:_Scenario_App_Integration_Tests__3_/stdout Fixes flutter/flutter#140192 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn off XCUITest attachment collection in iOS tests, which by default get saved for failing tests. This is failing in Xcode 11.x on the command line, and the logs are mostly spew from that, which hides other failures:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8875129688297197088/+/steps/Scenario_App_Integration_Tests/0/stdout
Additionally, only save goldens attachments when either the comparison golden isn't found, or the screenshot doesn't match the golden. Do not save attachments when the test passes.
Related Issues
Found as part of flutter/flutter#61267 investigation.
Tests
https://ci.chromium.org/swarming/task/4d638c548f418810?server=chromium-swarm.appspot.com