This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[gn] Extract target_os, target_cpu resolution #33224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
extract-target-os-cpu
branch
3 times, most recently
from
53a893f to
5cdcfcc
Compare
zanderso
reviewed
May 10, 2022
This is a minor refactoring to extract functions that resolve target_os and target_cpu gn settings. This is cleanup prior to adding support for host builds on Apple Silicon Macs. Issue: flutter/flutter#96745
cbracken
force-pushed
the
extract-target-os-cpu
branch
from
5cdcfcc to
067284f
Compare
zanderso
approved these changes
May 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
zanderso
added a commit
that referenced
this pull request
May 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring to extract functions that resolve target_os
and target_cpu gn settings.
This is cleanup prior to adding support for host builds on Apple Silicon
Macs.
Issue: flutter/flutter#96745
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.