Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[linux] Eliminate mirrors support #39701

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Feb 17, 2023

Support for using dart:mirrors has been deprecated for nearly two years. this removes support for enabling mirrors from the embedder as documented in the deprecation comment. This was primarily added as a workaround for an internal tooling usecase, which no longer exists.

Issue: flutter/flutter#120924

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Support for using dart:mirrors has been deprecated for nearly two years.
this removes support for enabling mirrors from the embedder as
documented in the deprecation comment. This was primarily added as a
workaround for an internal tooling usecase, which no longer exists.

Issue: flutter/flutter#120924
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cbracken cbracken merged commit 6d93874 into flutter:main Feb 17, 2023
@cbracken cbracken deleted the linux-no-mirrors branch February 17, 2023 17:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 17, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 17, 2023
…121004)

* 6a2a46a28 Roll Dart SDK from 3ec7f1f92216 to 7642080abaf7 (2 revisions) (flutter/engine#39702)

* f6bb7ae5f Roll Skia from d0df677ffd5e to ba60fed7f075 (6 revisions) (flutter/engine#39703)

* 27696d2b7 Cached DisplayList opacity inheritance fix (flutter/engine#39690)

* 1ae94738d Roll Dart SDK from 7642080abaf7 to 42829b6f80b1 (1 revision) (flutter/engine#39707)

* 676201790 Roll Fuchsia Linux SDK from yT4JLKTCWWwbRwB0l... to tMm2Lzb-LE20Rxwm9... (flutter/engine#39709)

* 26f1f251f Roll Skia from ba60fed7f075 to 5637cd56be32 (3 revisions) (flutter/engine#39710)

* 4b0b8f053 Roll Dart SDK from 42829b6f80b1 to c7ec16304216 (1 revision) (flutter/engine#39711)

* 1f7aad3a4 Roll Fuchsia Mac SDK from haDvcC5VzWVdQs9Rs... to _wymybZYKzX_3iFd6... (flutter/engine#39715)

* 067369d22 Migrate skia png codec call to public interface (flutter/engine#39714)

* 7e190a49c Roll Dart SDK from c7ec16304216 to 8a7dc36cadf6 (1 revision) (flutter/engine#39716)

* 83a896250 Roll Skia from 5637cd56be32 to 02890036028e (2 revisions) (flutter/engine#39717)

* 6d9387433 [linux] Eliminate mirrors support (flutter/engine#39701)

* adc0ebd97 Adds a Linux Fuchsia FEMU config that enables CSO (flutter/engine#39718)

* 0378b3406 [impeller] support generating mip-maps on Vulkan (flutter/engine#39689)

* 5212ac439 [Impeller] Device default attachment pixel formats (flutter/engine#39655)

* bd37a3992 Rollback Dart SDK to unblock the roller (flutter/engine#39722)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants