Added CI step for building with validation layers #42724

gaaclarke · 2023-06-10T15:23:00Z

Let's try to make sure the validation layers don't break.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2023-06-12T16:47:36Z

ci/builders/linux_android_debug_engine.json

+                "--no-lto",
+                "--enable-vulkan-validation-layers"
+            ],
+            "name": "android_debug_arm64",


I tried to give this a unique name but it didn't work since that name has to match the name of the generated directory by GN.

Have you tried keeping the name and the ninja config same when using the unique name?

yep, i don't know if there is an easy way to recall that failure though since I rebased.

Checked the history build of https://ci.chromium.org/p/flutter/builders/try/Linux%20linux_android_debug_engine?limit=50, are you referring to https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_debug_engine/11608/overview? The failed build run is: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/972265/overview

But the input properties shows "config": "android_debug_arm64":

"build": { "archives": [], "drone_dimensions": [ "device_type=none", "os=Linux" ], "gn": [ "--android", "--android-cpu=arm64", "--no-lto", "--enable-vulkan-validation-layers" ], "name": "android_debug_arm64_validation_layers", "ninja": { "config": "android_debug_arm64", "targets": [ "flutter", "flutter/shell/platform/android:abi_jars" ] }, "recipe": "engine_v2/builder" },

I'm pretty sure I tried it. I just pushed that change to be sure.

Nit: use a different name, say your earlier change android_debug_arm64_validation_layers, to distinguish the builds. Now it shows two same builds (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_debug_engine/11686/overview):

@keyonghan I can't use a different name, right? We tried that above.

with cas_archive = false is safe to use a different name.

With "cas_archive": false,, I would expect the build to pass.

yep, worked with that field: #42826

godofredoc · 2023-06-12T23:46:44Z

ci/builders/linux_android_debug_engine.json

+            ],
+            "name": "android_debug_arm64_validation_layers",
+            "ninja": {
+                "config": "android_debug_arm64_validation_layers",


replace config here with android_debug_arm64, https://github.com/flutter/engine/tree/main/ci/builders#ninja.

godofredoc · 2023-06-12T23:48:18Z

ci/builders/linux_android_debug_engine.json

+                "--no-lto",
+                "--enable-vulkan-validation-layers"
+            ],
+            "name": "android_debug_arm64_validation_layers",


You'll also need a "cas_archive": false here. https://github.com/flutter/engine/tree/main/ci/builders#archives

This appears to be what I was missing. I was thinking having an empty archive field would be the same thing as this.

…engine#42724)

…128841) flutter/engine@66a5761...727b441 2023-06-13 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" (flutter/engine#42823) 2023-06-13 [email protected] Roll Dart SDK from 41234fa4b22d to 2465228c0c21 (1 revision) (flutter/engine#42822) 2023-06-13 [email protected] [Impeller] Added cache for command buffers in vulkan (flutter/engine#42793) 2023-06-13 [email protected] setupDefultFontManager correctly clear out cache (flutter/engine#42178) 2023-06-13 [email protected] [Impeller] Reland attempt Vulkan setup and fallback to GLES. (flutter/engine#42820) 2023-06-13 [email protected] Added CI step for building with validation layers (flutter/engine#42724) 2023-06-13 [email protected] [Impeller] Null check for the device holder in the Vulkan context destructor (flutter/engine#42821) 2023-06-13 [email protected] Add missing includes (flutter/engine#42812) 2023-06-13 [email protected] Roll Dart SDK from 4dce1093ad94 to 41234fa4b22d (1 revision) (flutter/engine#42810) 2023-06-13 [email protected] [iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter. (flutter/engine#42312) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

followup to #42724 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

gaaclarke force-pushed the validation-layers-ci branch 2 times, most recently from f3fd928 to 8f9b6c2 Compare June 12, 2023 16:35

gaaclarke marked this pull request as draft June 12, 2023 16:37

gaaclarke force-pushed the validation-layers-ci branch from 8f9b6c2 to 9d6f43a Compare June 12, 2023 16:40

gaaclarke commented Jun 12, 2023

View reviewed changes

gaaclarke mentioned this pull request Jun 12, 2023

engine_v2: unable to add duplicate build with different flags flutter/flutter#128710

Closed

Added CI step for building with validation layers

4d7a27a

gaaclarke force-pushed the validation-layers-ci branch from 9d6f43a to 4d7a27a Compare June 12, 2023 21:06

godofredoc reviewed Jun 12, 2023

View reviewed changes

added cas_archive:false

c2bbe70

gaaclarke marked this pull request as ready for review June 13, 2023 19:38

gaaclarke requested review from keyonghan and godofredoc June 13, 2023 19:38

godofredoc approved these changes Jun 13, 2023

View reviewed changes

gaaclarke merged commit 4c2bae7 into flutter:main Jun 13, 2023

gaaclarke mentioned this pull request Jun 13, 2023

Renamed validation layers build #42826

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Jun 14, 2023

Roll Flutter Engine from 66a5761412f9 to 727b4413fe6f (10 revisions) flutter/flutter#128841

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 14, 2023

4c2bae79c Added CI step for building with validation layers (flutter/…

6e5e10e

…engine#42724)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added CI step for building with validation layers #42724

Added CI step for building with validation layers #42724

Uh oh!

gaaclarke commented Jun 10, 2023

Uh oh!

gaaclarke Jun 12, 2023

Uh oh!

keyonghan Jun 12, 2023

Uh oh!

gaaclarke Jun 12, 2023

Uh oh!

keyonghan Jun 12, 2023

Uh oh!

gaaclarke Jun 12, 2023

Uh oh!

keyonghan Jun 13, 2023 •

edited

Loading

Uh oh!

gaaclarke Jun 13, 2023

Uh oh!

godofredoc Jun 13, 2023

Uh oh!

keyonghan Jun 13, 2023

Uh oh!

gaaclarke Jun 13, 2023

Uh oh!

godofredoc Jun 12, 2023

Uh oh!

godofredoc Jun 12, 2023 •

edited

Loading

Uh oh!

gaaclarke Jun 13, 2023

Uh oh!

Uh oh!

Added CI step for building with validation layers #42724

Added CI step for building with validation layers #42724

Uh oh!

Conversation

gaaclarke commented Jun 10, 2023

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

godofredoc Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keyonghan Jun 13, 2023 •

edited

Loading

godofredoc Jun 12, 2023 •

edited

Loading