Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS] Eliminate archive_gen_snapshot target #53948

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[macOS] Eliminate archive_gen_snapshot target #53948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions build/archives/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,23 +272,7 @@ if (host_os == "win") {
}
}

# Archives Flutter Mac Artifacts
if (is_mac) {
zip_bundle("archive_gen_snapshot") {
deps = [ "//flutter/lib/snapshot:create_macos_gen_snapshots" ]
suffix = "-$flutter_runtime_mode"
if (flutter_runtime_mode == "debug") {
suffix = ""
}
output = "$full_platform_name$suffix/gen_snapshot.zip"
files = [
{
source = "${root_out_dir}/gen_snapshot_${target_cpu}"
destination = "gen_snapshot_${target_cpu}"
},
]
}

group("flutter_embedder_framework") {
deps = [
"//flutter/shell/platform/embedder:flutter_embedder_framework_archive",
Expand Down
10 changes: 5 additions & 5 deletions ci/builders/mac_host_engine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@
"ninja": {
"config": "ci/host_debug",
"targets": [
"flutter/build/archives:archive_gen_snapshot",
"flutter/build/archives:artifacts",
"flutter/build/archives:dart_sdk_archive",
"flutter/build/archives:flutter_embedder_framework",
"flutter/build/dart:copy_dart_sdk",
"flutter/lib/snapshot:create_macos_gen_snapshots",
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
"flutter/tools/font_subset",
"flutter:unittests"
Expand Down Expand Up @@ -127,8 +127,8 @@
"config": "ci/host_profile",
"targets": [
"flutter/build/dart:copy_dart_sdk",
"flutter/build/archives:archive_gen_snapshot",
"flutter/build/archives:artifacts",
"flutter/lib/snapshot:create_macos_gen_snapshots",
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
"flutter:unittests"
]
Expand Down Expand Up @@ -214,9 +214,9 @@
"ninja": {
"config": "ci/host_release",
"targets": [
"flutter/build/archives:archive_gen_snapshot",
"flutter/build/archives:artifacts",
"flutter/build/dart:copy_dart_sdk",
"flutter/lib/snapshot:create_macos_gen_snapshots",
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
"flutter/tools/font_subset",
"flutter:unittests"
Expand Down Expand Up @@ -298,10 +298,10 @@
"config": "ci/mac_debug_arm64",
"targets": [
"flutter/tools/font_subset",
"flutter/build/archives:archive_gen_snapshot",
"flutter/build/archives:artifacts",
"flutter/build/archives:dart_sdk_archive",
"flutter/build/archives:flutter_embedder_framework",
"flutter/lib/snapshot:create_macos_gen_snapshots",
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework"
]
},
Expand Down Expand Up @@ -442,10 +442,10 @@
"config": "ci/mac_release_arm64",
"targets": [
"flutter:unittests",
"flutter/build/archives:archive_gen_snapshot",
"flutter/build/archives:artifacts",
"flutter/build/dart:copy_dart_sdk",
"flutter/impeller/golden_tests:impeller_golden_tests",
"flutter/lib/snapshot:create_macos_gen_snapshots",
"flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
"flutter/tools/font_subset"
]
Expand Down