This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix build/dart/rules.gni which contains erroneous code after my refactor.
#54867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Aug 29, 2024
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2024
…154358) flutter/engine@27a04c9...8c27891 2024-08-29 [email protected] Fix `build/dart/rules.gni` which contains erroneous code after my refactor. (flutter/engine#54867) 2024-08-29 [email protected] Roll Skia from 20b3af58d4a5 to 10e44e318a72 (1 revision) (flutter/engine#54869) 2024-08-29 [email protected] Roll Fuchsia Linux SDK from ZL8AvfXX5LFIH1LYN... to ohUS2y1HixZYziUtX... (flutter/engine#54868) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZL8AvfXX5LFI to ohUS2y1HixZY If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#154358) flutter/engine@27a04c9...8c27891 2024-08-29 [email protected] Fix `build/dart/rules.gni` which contains erroneous code after my refactor. (flutter/engine#54867) 2024-08-29 [email protected] Roll Skia from 20b3af58d4a5 to 10e44e318a72 (1 revision) (flutter/engine#54869) 2024-08-29 [email protected] Roll Fuchsia Linux SDK from ZL8AvfXX5LFIH1LYN... to ohUS2y1HixZYziUtX... (flutter/engine#54868) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZL8AvfXX5LFI to ohUS2y1HixZY If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #54845, I removed
common_vm_args = ['--disable-dart-dev'], but the resulting change created invalid codevm_args = (args = common_args). We don't seem to run this configuration on our own CI, so it wasn't noticed, but it broke the Dart monorepo build, which does use it:https://ci.chromium.org/p/dart/g/monorepo/console
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738311211510911329/+/u/gn_--runtime-mode_debug_--full-dart-sdk_--rbe_--no-goma_--unoptimized_--no-prebuilt-dart-sdk_--gn-args_engine_version__5295ec1b816af727165015d84d4a1091520122ae__--rbe-server-address_unix:___b_s_w_ir_x_w_recipe_cleanup_rbe4v23ir8o_reproxy.sock/stdout
I am open to reverting instead, but this seems straight-forward enough for something that isn't tested on either pre or post-submit.