This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Stack squishes positioned elements near the edge #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When laying out positioned children inside a stack, we should give them unbounded constraints because if they draw outside of the stack, we'll just clip them.
|
LGTM |
abarth
added a commit
that referenced
this pull request
Aug 20, 2015
Stack squishes positioned elements near the edge
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Allow hard splits inside string interpolation. Removing *all* splits broken several things. In particular, multiline strings and line comments inside interpolation really do need to maintain their splits. This allows all hard splits to split but not soft splits. It also allows collection literals to split. That's not ideal, but it should be a rare case anyway. If you don't want that to split, don't have a collection literal inside a string interpolation in a line that doesn't fit the page width. Fix flutter#711. * Add another edge case test. * Bump version and update changelog. * Revise README.
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 18, 2023
Changes since last roll: ``` 059d155 [dart] Add identifier needed for zlib roll (flutter#718) 459d3e5 Bump github/codeql-action from 2.2.11 to 2.2.12 (flutter#716) 91f1ba5 Bump actions/checkout from 3.5.1 to 3.5.2 (#715) 2e5c483 Bump actions/checkout from 3.5.0 to 3.5.1 (flutter#714) a5af13d Remove codeql. (flutter#713) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
Bump actions/checkout from 3.5.0 to 3.5.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When laying out positioned children inside a stack, we should give them
unbounded constraints because if they draw outside of the stack, we'll just
clip them.