-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Closed
flutter/packages
#3020Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specifically
Description
Making a Pigeon HostApi definition including:
void setValue(String key, Object value);
generates code including:
let valueArg = args[1] as! Any
This creates the following warning at compile time:
.../messages.g.swift:73:32: warning: forced cast from 'Any?' to 'Any' only unwraps optionals; did you mean to use '!'?
let valueArg = args[1] as! Any
We should special-case Object
so that it generates let valueArg = args[1]!
instead.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specifically