Skip to content

Updates the package dependencies by running flutter update-packages --force-upgrade #13906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

gspencergoog
Copy link
Contributor

This simply updates the package dependencies by running flutter update-packages --force-upgrade.

I'm doing this with no other changes, because the last time I tried that, redness occurred. I want to isolate the problem to a "clean" update of the packages.

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Jan 4, 2018

OK, it looks like the plugins device_info, connectivity, and url_launcher haven't yet had their gradle configurations updated, so they fail when trying to build with the new gradle. I reverted the upgrade for those three packages only (in flutter_gallery) until we are ready to fix them (fixing them for master will break them for alpha users, so we need to do an alpha roll to do that).

@gspencergoog gspencergoog changed the title Update packages Updates the package dependencies by running flutter update-packages --force-upgrade Jan 4, 2018
@Hixie
Copy link
Contributor

Hixie commented Jan 4, 2018

RSLGTM

@Hixie
Copy link
Contributor

Hixie commented Jan 6, 2018

For future reference, when pinning a dependency, you should update update_packages.dart's pin map, rather than doing it by hand.

@zoechi
Copy link
Contributor

zoechi commented Jan 7, 2018

Curious why you don't just commit pubspec.lock instead of maintaining transitive dependency versions in pubspec.yaml manually

@Hixie
Copy link
Contributor

Hixie commented Jan 7, 2018

@zoechi Well we can't do that for the flutter package, since packages don't have .lock files, only applications do. But see #13428 about doing it for the applications that we ship.

@gspencergoog gspencergoog deleted the update_packages branch February 12, 2018 18:12
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
…-force-upgrade (flutter#13906)

This simply updates the package dependencies by running flutter update-packages --force-upgrade.

I'm doing this with no other changes, because the last time I tried that, redness occurred. I want to isolate the problem to a "clean" update of the packages.

It looks like the plugins device_info, connectivity, and url_launcher haven't yet had their gradle configurations updated, so they fail when trying to build with the new gradle. I did not upgrade for those three packages only (in flutter_gallery) until we are ready to fix them (fixing them for master will break them for alpha users, so we need to do an alpha roll to do that).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants