Skip to content

Mark windows_host_engine_test flaky #167419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Mark windows_host_engine_test flaky #167419

merged 1 commit into from
Apr 18, 2025

Conversation

matanlurey
Copy link
Contributor

See #167418.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Apr 18, 2025
@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Apr 18, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
@jtmcdole
Copy link
Member

Looks like:
WindowsTest.LaunchMainHasNoOutput
EmbedderTest.PlatformThreadIsolatesWithCustomPlatformTaskRunner

jtmcdole
jtmcdole approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved so we can dive in

@matanlurey matanlurey added this pull request to the merge queue Apr 18, 2025
@loic-sharma loic-sharma mentioned this pull request Apr 18, 2025
Merged
@loic-sharma
Copy link
Member

loic-sharma commented Apr 18, 2025 •
edited
Loading

Can we use #167420 to unblock the tree instead of turning off Window's engine tests?

Merged via the queue into master with commit 7f136e2 Apr 18, 2025
182 of 183 checks passed
@matanlurey matanlurey deleted the matanlurey-patch-5 branch April 18, 2025 21:49
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
alex-medinsh pushed a commit to alex-medinsh/flutter that referenced this pull request Apr 18, 2025
@matanlurey @alex-medinsh
Mark windows_host_engine_test flaky (flutter#167419)
a08fd89 
See flutter#167418.
@loic-sharma
Copy link
Member

Reason for revert: Test should no longer be flaky now that #167420 has landed.

@loic-sharma loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 18, 2025
auto-submit bot pushed a commit that referenced this pull request Apr 18, 2025
Revert "Mark windows_host_engine_test flaky (#167419)"
43f4012 
This reverts commit 7f136e2.
@auto-submit auto-submit bot mentioned this pull request Apr 18, 2025
Merged
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Apr 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2025
@auto-submit
Reverts "Mark windows_host_engine_test flaky (#167419)" (#167425)
8785fb3 
<!-- start_original_pr_link -->
Reverts: #167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
#167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See #167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025
@engine-flutter-autoroll
7f136e268 Mark windows_host_engine_test flaky (flutter/flutter#167419)
36c5087
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025
@engine-flutter-autoroll
7f136e268 Mark windows_host_engine_test flaky (flutter/flutter#167419)
5202537
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2025
@engine-flutter-autoroll
7f136e268 Mark windows_host_engine_test flaky (flutter/flutter#167419)
8400cdc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 20, 2025
@engine-flutter-autoroll
Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) (#9118)
ac21f53 
flutter/flutter@3ed38e2...cfb887c

2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
raju-muliyashiya pushed a commit to raju-muliyashiya/flutter_packages that referenced this pull request Apr 26, 2025
@engine-flutter-autoroll @raju-muliyashiya
Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) (flutte…
f89f888 
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/flutter that referenced this pull request May 15, 2025
@auto-submit
Reverts "Mark windows_host_engine_test flaky (#167419)" (#167425)
238185f 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
flutter/flutter#167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See flutter/flutter#167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) (flutte…
e6c3d0a 
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) (flutte…
3a2848c 
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) (flutte…
a27b840 
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matanlurey @jtmcdole @loic-sharma