[go_router] Adds `caseSensitive` to `GoRoute` #8992

ValentinVignal · 2025-04-03T16:25:29Z

Fixes flutter/flutter#162487
Fixes flutter/flutter#166576

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

ValentinVignal · 2025-04-03T16:27:02Z

packages/go_router/lib/src/route.dart

@@ -275,6 +275,7 @@ class GoRoute extends RouteBase {
    super.parentNavigatorKey,
    super.redirect,
    this.onExit,
+    this.caseSensitive = false,


@chunhtai, from your comment flutter/flutter#162487 (comment),

based on https://www.w3.org/TR/WD-html40-970708/htmlweb.html, the URL should be case sensitive

I prefer to set the default to `true, ' but that would be a breaking change. I'm fine writing a migration doc

What do you prefer me to do?

I agree we should probably default it to true to provide the correct behavior by default, but yeah we should bump major version and a breaking change doc if we do that

Ok ! Will do !

ValentinVignal · 2025-04-04T11:31:01Z

Converting as draft while the design doc is being written and the code updated

ValentinVignal · 2025-04-04T12:05:59Z

Design document has been created:

flutter/website#11867
flutter/flutter#166576
https://flutter.dev/go/go-router-v15-breaking-changes

ValentinVignal · 2025-04-04T12:19:04Z

@chunhtai The URL is now case sensitive by default

Adds the migration guide for go_router v15 (See flutter/packages#8992, and more precisely flutter/packages#8992 (comment)) ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.

ValentinVignal · 2025-04-08T00:26:06Z

The migration guide has been merged and is now available at the go url

packages/go_router/lib/src/route.dart

chunhtai · 2025-04-14T17:35:18Z

packages/go_router/lib/src/match.dart

@@ -218,7 +218,17 @@ abstract class RouteMatchBase with Diagnosticable {
    final String newMatchedLocation =
        concatenatePaths(matchedLocation, pathLoc);
    final String newMatchedPath = concatenatePaths(matchedPath, route.path);
-    if (newMatchedLocation.toLowerCase() == uri.path.toLowerCase()) {
+
+    final String caseSensitiveNewMatchedLocation;


I think the new name is more confusing than the old name, because it can contains case insensitive string in the else case

Fair enough, What do you think of newMatchedLocationToCompare and uriPathToCompare ? I added them in Add better name and documentation

chunhtai · 2025-04-14T17:36:01Z

packages/go_router/lib/src/route.dart

@@ -437,6 +438,9 @@ class GoRoute extends RouteBase {
  /// ```
  final ExitCallback? onExit;

+  /// Whether the path is case sensitive or not.


Can you add more description? perhaps with some example

Sure, I added more in Add better name and documentation, tell me if you need more

chunhtai

LGTM, thanks for fixing this!

auto-submit · 2025-04-16T00:24:09Z

autosubmit label was removed for flutter/packages/8992, because - The status or check suite Mac_arm64 custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ages#8992)

flutter/packages@2fcc403...ac21f53 2025-04-20 [email protected] Roll Flutter from 3ed38e2 to cfb887c (17 revisions) (flutter/packages#9118) 2025-04-19 [email protected] [various] Scrubs pre-SDK-21 Android code (flutter/packages#9112) 2025-04-18 [email protected] Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (flutter/packages#9114) 2025-04-18 [email protected] [flutter_svg] feat: Expose the `colorMapper` property in `SvgPicture` (flutter/packages#9043) 2025-04-18 [email protected] [tool] Add initial file-based command skipping (flutter/packages#8928) 2025-04-18 [email protected] [pigeon] Convert test plugins to SPM (flutter/packages#9105) 2025-04-18 [email protected] [webview_flutter] Adds support to control overscrolling (flutter/packages#8451) 2025-04-17 [email protected] [in_app_purchase] add Storefront.countryCode() and AppStore.sync() (flutter/packages#8900) 2025-04-17 [email protected] [webview_flutter_wkwebview] Expose the allowsLinkPreview property in WKWebView for iOS (flutter/packages#5029) 2025-04-17 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations to set over-scroll mode (flutter/packages#9101) 2025-04-17 [email protected] [shared_preferences] Update AGP to 8.9.1 (flutter/packages#9106) 2025-04-17 [email protected] [pigeon] Adds Kotlin lint tests to example code and fix lints (flutter/packages#9034) 2025-04-17 [email protected] [video_player_avfoundation] enable more than 30 fps (flutter/packages#7466) 2025-04-17 [email protected] Roll Flutter from aef4718 to ecabb1a (25 revisions) (flutter/packages#9104) 2025-04-16 [email protected] [pigeon] Unify iOS and macOS test plugins (flutter/packages#9100) 2025-04-16 [email protected] Roll Flutter from db68c95 to aef4718 (7 revisions) (flutter/packages#9098) 2025-04-16 [email protected] [webview_flutter_platform_interface] Adds method to set overscroll mode (flutter/packages#9099) 2025-04-16 [email protected] Update `CODEOWNERS` (flutter/packages#8984) 2025-04-16 [email protected] [google_sign_is] Update iOS SDK to 8.0 (flutter/packages#9081) 2025-04-16 [email protected] [camera_avfoundation] Implementation swift migration (flutter/packages#8988) 2025-04-16 [email protected] [go_router] Adds `caseSensitive` to `GoRoute` (flutter/packages#8992) 2025-04-16 [email protected] Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) (flutter/packages#9092) 2025-04-15 [email protected] [tool] Run config-only build for iOS/macOS native-test (flutter/packages#9080) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@2fcc403...ac21f53 2025-04-20 [email protected] Roll Flutter from 409a8ac to cd51fa3 (17 revisions) (flutter/packages#9118) 2025-04-19 [email protected] [various] Scrubs pre-SDK-21 Android code (flutter/packages#9112) 2025-04-18 [email protected] Roll Flutter from d0741df to 409a8ac (23 revisions) (flutter/packages#9114) 2025-04-18 [email protected] [flutter_svg] feat: Expose the `colorMapper` property in `SvgPicture` (flutter/packages#9043) 2025-04-18 [email protected] [tool] Add initial file-based command skipping (flutter/packages#8928) 2025-04-18 [email protected] [pigeon] Convert test plugins to SPM (flutter/packages#9105) 2025-04-18 [email protected] [webview_flutter] Adds support to control overscrolling (flutter/packages#8451) 2025-04-17 [email protected] [in_app_purchase] add Storefront.countryCode() and AppStore.sync() (flutter/packages#8900) 2025-04-17 [email protected] [webview_flutter_wkwebview] Expose the allowsLinkPreview property in WKWebView for iOS (flutter/packages#5029) 2025-04-17 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations to set over-scroll mode (flutter/packages#9101) 2025-04-17 [email protected] [shared_preferences] Update AGP to 8.9.1 (flutter/packages#9106) 2025-04-17 [email protected] [pigeon] Adds Kotlin lint tests to example code and fix lints (flutter/packages#9034) 2025-04-17 [email protected] [video_player_avfoundation] enable more than 30 fps (flutter/packages#7466) 2025-04-17 [email protected] Roll Flutter from 9616f9c to d0741df (25 revisions) (flutter/packages#9104) 2025-04-16 [email protected] [pigeon] Unify iOS and macOS test plugins (flutter/packages#9100) 2025-04-16 [email protected] Roll Flutter from a7ce7ff to 9616f9c (7 revisions) (flutter/packages#9098) 2025-04-16 [email protected] [webview_flutter_platform_interface] Adds method to set overscroll mode (flutter/packages#9099) 2025-04-16 [email protected] Update `CODEOWNERS` (flutter/packages#8984) 2025-04-16 [email protected] [google_sign_is] Update iOS SDK to 8.0 (flutter/packages#9081) 2025-04-16 [email protected] [camera_avfoundation] Implementation swift migration (flutter/packages#8988) 2025-04-16 [email protected] [go_router] Adds `caseSensitive` to `GoRoute` (flutter/packages#8992) 2025-04-16 [email protected] Manual roll Flutter from f2d54fd to a7ce7ff (98 revisions) (flutter/packages#9092) 2025-04-15 [email protected] [tool] Run config-only build for iOS/macOS native-test (flutter/packages#9080) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes flutter/flutter#162487 Fixes flutter/flutter#166576 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

ValentinVignal requested a review from chunhtai as a code owner April 3, 2025 16:25

github-actions bot added the p: go_router label Apr 3, 2025

ValentinVignal commented Apr 3, 2025

View reviewed changes

ValentinVignal marked this pull request as draft April 4, 2025 11:31

This was referenced Apr 4, 2025

Add the go router v15 migration guide flutter/website#11867

Merged

Add go_router 15 migration guide flutter/flutter#166576

Closed

ValentinVignal marked this pull request as ready for review April 4, 2025 12:18

lcf123321 mentioned this pull request Apr 4, 2025

就是这样子的操作 flutter/flutter#166577

Closed

ValentinVignal force-pushed the go-router/Add-case-sensitive-to-go-route branch from e4aff26 to ca1432f Compare April 8, 2025 15:03

ValentinVignal commented Apr 8, 2025

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

chunhtai reviewed Apr 14, 2025

View reviewed changes

ValentinVignal requested a review from chunhtai April 15, 2025 09:53

chunhtai approved these changes Apr 15, 2025

View reviewed changes

ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

ValentinVignal added 7 commits April 16, 2025 14:43

Add GoRoute.caseSensitive

8ea0d29

Add test

cd1e07f

Update version

64e4607

Make case sensitive true by default

297bd2b

Update the documentation

98e7df4

Update the tests

16cadc5

Add better name and documentation

12f0136

ValentinVignal force-pushed the go-router/Add-case-sensitive-to-go-route branch from 48ba286 to 12f0136 Compare April 16, 2025 06:43

ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

auto-submit bot merged commit b03228f into flutter:main Apr 16, 2025
82 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2025

b03228fba [go_router] Adds caseSensitive to GoRoute (flutter/pack…

da59ef0

…ages#8992)

engine-flutter-autoroll mentioned this pull request Apr 16, 2025

Roll Packages from 2fcc4032dd8b to 7172aaad3872 (5 revisions) flutter/flutter#167274

Closed

ValentinVignal mentioned this pull request Apr 16, 2025

[go_router_builder] Add caseSensitive property flutter/flutter#167277

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2025

b03228fba [go_router] Adds caseSensitive to GoRoute (flutter/pack…

2afd3b4

…ages#8992)

engine-flutter-autoroll mentioned this pull request Apr 21, 2025

Roll Packages from 2fcc4032dd8b to ac21f531a0cc (23 revisions) flutter/flutter#167479

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router] Adds `caseSensitive` to `GoRoute` #8992

[go_router] Adds `caseSensitive` to `GoRoute` #8992

Uh oh!

ValentinVignal commented Apr 3, 2025 •

edited

Loading

Uh oh!

ValentinVignal Apr 3, 2025

Uh oh!

chunhtai Apr 3, 2025

Uh oh!

ValentinVignal Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 8, 2025

Uh oh!

Uh oh!

Uh oh!

chunhtai Apr 14, 2025

Uh oh!

ValentinVignal Apr 15, 2025

Uh oh!

chunhtai Apr 14, 2025

Uh oh!

ValentinVignal Apr 15, 2025

Uh oh!

chunhtai left a comment

Uh oh!

auto-submit bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

[go_router] Adds caseSensitive to GoRoute #8992

[go_router] Adds caseSensitive to GoRoute #8992

Uh oh!

Conversation

ValentinVignal commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

ValentinVignal Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 4, 2025

Uh oh!

ValentinVignal commented Apr 8, 2025

Uh oh!

Uh oh!

Uh oh!

chunhtai Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

[go_router] Adds `caseSensitive` to `GoRoute` #8992

[go_router] Adds `caseSensitive` to `GoRoute` #8992

ValentinVignal commented Apr 3, 2025 •

edited

Loading