Skip to content

[video_player] Skip some integration tests on web #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

[video_player] Skip some integration tests on web #9302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e6a30f
Initial attempt at skipping tests; others will likely fail
stuartmorgan-g May 21, 2025
c2b81c8
Another skip
stuartmorgan-g May 21, 2025
f8659c4
Merge branch 'main' into video-player-skip-web
stuartmorgan-g May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/video_player/video_player/example/integration_test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,6 @@ void main() {
testWidgets(
'reports buffering status',
(WidgetTester tester) async {
// This test requires network access, and won't pass until a LUCI recipe
// change is made.
// TODO(camsim99): Remove once https://github.com/flutter/flutter/issues/160797 is fixed.
if (!kIsWeb && Platform.isAndroid) {
markTestSkipped(
'Skipping due to https://github.com/flutter/flutter/issues/160797');
return;
}

await controller.initialize();
// Mute to allow playing without DOM interaction on Web.
// See https://developers.google.com/web/updates/2017/09/autoplay-policy-changes
Expand Down Expand Up @@ -308,7 +299,11 @@ void main() {
await expectLater(started.future, completes);
await expectLater(ended.future, completes);
},
skip: !(kIsWeb || defaultTargetPlatform == TargetPlatform.android),
skip:
// MEDIA_ELEMENT_ERROR on web, see https://github.com/flutter/flutter/issues/169219
kIsWeb ||
// Hanging on Android, see https://github.com/flutter/flutter/issues/160797
defaultTargetPlatform == TargetPlatform.android,
);
});

Expand Down
8 changes: 6 additions & 2 deletions packages/video_player/video_player_web/example/integration_test/video_player_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ void main() {
isPlaying: true,
)
]));
});
},
// MEDIA_ELEMENT_ERROR, see https://github.com/flutter/flutter/issues/169219
skip: true);

testWidgets('video playback lifecycle', (WidgetTester tester) async {
final int videoPlayerId = await playerId;
Expand Down Expand Up @@ -238,7 +240,9 @@ void main() {
VideoEventType.initialized,
VideoEventType.bufferingEnd,
]));
});
},
// MEDIA_ELEMENT_ERROR, see https://github.com/flutter/flutter/issues/169219
skip: true);

testWidgets('can set web options', (WidgetTester tester) async {
expect(
Expand Down