This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Image picker phpicker impl #3835
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,7 +165,7 @@ - (void)launchPickerAndPick { | |
| // Find an image and tap on it. (IOS 14 UI, images are showing directly) | ||
| XCUIElement* aImage; | ||
| if (@available(iOS 14, *)) { | ||
| aImage = [self.app.scrollViews.firstMatch.images elementBoundByIndex:1]; | ||
|
There was a problem hiding this comment. Why do we need to select the 2nd element instead of 2? Is this a critical change or just that you think testing the 2nd image is better? There was a problem hiding this comment. This is because there is a known issue to pick HEIC images with PHPicker implementation. But only for simulators. So we have two options here. Either test with real device or test with non-HEIC images until Apple solves the issue. |
||
| } else { | ||
| XCUIElement* allPhotosCell = [self.app.cells | ||
| elementMatchingPredicate:[NSPredicate predicateWithFormat:@"label == %@", @"All Photos"]]; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,185 @@ | ||
| // | ||
| // ImagePickerFromLimitedGalleryUITests.m | ||
| // RunnerUITests | ||
| // | ||
| // Created by Yusuf Dag on 28/04/2021. | ||
| // Copyright © 2021 The Flutter Authors. All rights reserved. | ||
| // | ||
cyanglaz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| #import <XCTest/XCTest.h> | ||
| #import <os/log.h> | ||
|
|
||
| const int kLimitedElementWaitingTime = 30; | ||
|
|
||
| @interface ImagePickerFromLimitedGalleryUITests : XCTestCase | ||
|
|
||
| @property(nonatomic, strong) XCUIApplication* app; | ||
|
|
||
| @end | ||
|
|
||
| @implementation ImagePickerFromLimitedGalleryUITests | ||
|
|
||
| - (void)setUp { | ||
| [super setUp]; | ||
| // Delete the app if already exists, to test permission popups | ||
|
|
||
| self.continueAfterFailure = NO; | ||
| self.app = [[XCUIApplication alloc] init]; | ||
| [self.app launch]; | ||
| __weak typeof(self) weakSelf = self; | ||
| [self addUIInterruptionMonitorWithDescription:@"Permission popups" | ||
| handler:^BOOL(XCUIElement* _Nonnull interruptingElement) { | ||
| if (@available(iOS 14, *)) { | ||
|
There was a problem hiding this comment. I think limited photos is only availabe in iOS 14? So maybe we should skip this test for ios 14 and below? This way we don't need to maintain 2 versions for this test. There was a problem hiding this comment. I am not sure how to do this. Using There was a problem hiding this comment. Sometime like this?: if (!(@available(iOS 14, *))) {
return;
}There was a problem hiding this comment. I used XCTSkip, I think it is done! |
||
| XCUIElement* limitedPhotoPermission = | ||
| [interruptingElement.buttons elementBoundByIndex:0]; | ||
| if (![limitedPhotoPermission | ||
| waitForExistenceWithTimeout: | ||
| kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", | ||
| weakSelf.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find " | ||
| @"selectPhotos butt on with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| [limitedPhotoPermission tap]; | ||
| } else { | ||
| XCUIElement* ok = interruptingElement.buttons[@"OK"]; | ||
| if (![ok waitForExistenceWithTimeout: | ||
| kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", | ||
| weakSelf.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find ok button " | ||
| @"with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| [ok tap]; | ||
| } | ||
| return YES; | ||
| }]; | ||
| } | ||
|
|
||
| - (void)tearDown { | ||
| [super tearDown]; | ||
| [self.app terminate]; | ||
| } | ||
|
|
||
| - (void)testSelectingFromGallery { | ||
| [self launchPickerAndSelect]; | ||
| } | ||
|
|
||
| - (void)launchPickerAndSelect { | ||
| // Find and tap on the pick from gallery button. | ||
| NSPredicate* predicateToFindImageFromGalleryButton = | ||
| [NSPredicate predicateWithFormat:@"label == %@", @"image_picker_example_from_gallery"]; | ||
|
|
||
| XCUIElement* imageFromGalleryButton = | ||
| [self.app.otherElements elementMatchingPredicate:predicateToFindImageFromGalleryButton]; | ||
| if (![imageFromGalleryButton waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find image from gallery button with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
|
|
||
| XCTAssertTrue(imageFromGalleryButton.exists); | ||
| [imageFromGalleryButton tap]; | ||
|
|
||
| // Find and tap on the `pick` button. | ||
| NSPredicate* predicateToFindPickButton = | ||
| [NSPredicate predicateWithFormat:@"label == %@", @"PICK"]; | ||
|
|
||
| XCUIElement* pickButton = [self.app.buttons elementMatchingPredicate:predicateToFindPickButton]; | ||
| if (![pickButton waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find pick button with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
|
|
||
| XCTAssertTrue(pickButton.exists); | ||
| [pickButton tap]; | ||
|
|
||
| // There is a known bug where the permission popups interruption won't get fired until a tap | ||
| // happened in the app. We expect a permission popup so we do a tap here. | ||
| [self.app tap]; | ||
|
|
||
| // Find an image and tap on it. (IOS 14 UI, images are showing directly) | ||
| XCUIElement* aImage; | ||
| if (@available(iOS 14, *)) { | ||
| aImage = [self.app.scrollViews.firstMatch.images elementBoundByIndex:1]; | ||
| } else { | ||
| XCUIElement* selectedPhotosCell = [self.app.cells | ||
| elementMatchingPredicate:[NSPredicate | ||
| predicateWithFormat:@"label == %@", @"Selected Photos"]]; | ||
| if (![selectedPhotosCell waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find \"Selected Photos\" cell with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| [selectedPhotosCell tap]; | ||
| aImage = [self.app.collectionViews elementMatchingType:XCUIElementTypeCollectionView | ||
| identifier:@"PhotosGridView"] | ||
| .cells.firstMatch; | ||
| } | ||
| os_log_error(OS_LOG_DEFAULT, "description before picking image %@", self.app.debugDescription); | ||
| if (![aImage waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find an image with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| XCTAssertTrue(aImage.exists); | ||
| [aImage tap]; | ||
|
|
||
| // Find and tap on the `Done` button. | ||
| NSPredicate* predicateToFindDoneButton = | ||
| [NSPredicate predicateWithFormat:@"label == %@", @"Done"]; | ||
|
|
||
| XCUIElement* doneButton = [self.app.buttons elementMatchingPredicate:predicateToFindDoneButton]; | ||
| if (![doneButton waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find Cancel button with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
|
|
||
| XCTAssertTrue(doneButton.exists); | ||
| [doneButton tap]; | ||
|
|
||
| // Find an image and tap on it to have access to selected photos. | ||
| if (@available(iOS 14, *)) { | ||
| aImage = [self.app.scrollViews.firstMatch.images elementBoundByIndex:1]; | ||
| } else { | ||
| XCUIElement* selectedPhotosCell = [self.app.cells | ||
| elementMatchingPredicate:[NSPredicate | ||
| predicateWithFormat:@"label == %@", @"Selected Photos"]]; | ||
| if (![selectedPhotosCell waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find \"Selected Photos\" cell with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| [selectedPhotosCell tap]; | ||
| aImage = [self.app.collectionViews elementMatchingType:XCUIElementTypeCollectionView | ||
| identifier:@"PhotosGridView"] | ||
| .cells.firstMatch; | ||
| } | ||
| os_log_error(OS_LOG_DEFAULT, "description before picking image %@", self.app.debugDescription); | ||
| if (![aImage waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find an image with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
| XCTAssertTrue(aImage.exists); | ||
| [aImage tap]; | ||
|
|
||
| // Find the picked image. | ||
| NSPredicate* predicateToFindPickedImage = | ||
| [NSPredicate predicateWithFormat:@"label == %@", @"image_picker_example_picked_image"]; | ||
|
|
||
| XCUIElement* pickedImage = [self.app.images elementMatchingPredicate:predicateToFindPickedImage]; | ||
| if (![pickedImage waitForExistenceWithTimeout:kLimitedElementWaitingTime]) { | ||
| os_log_error(OS_LOG_DEFAULT, "%@", self.app.debugDescription); | ||
| XCTFail(@"Failed due to not able to find pickedImage with %@ seconds", | ||
| @(kLimitedElementWaitingTime)); | ||
| } | ||
|
|
||
| XCTAssertTrue(pickedImage.exists); | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.