Integrate vfsharp feb 25 to mar 29 #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix build when proto is built * Update dotnet cli, remove unused BuildToolsVersion.txt file
* Replace hats * Add spaces
* warnings as error again * update warnings as errors
* Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * improve diagnostics * fix tests * fix determinism
* process large expressions systematically * add test cases * update tests * Make .NET Desktop fsi.exe 32-bit again and make Desktop fsiAnyCpu.exe (64-bit) the default to launch in VS #6223 * make fsc.exe 32-bit for compat * make fsc.exe 32-bit for compat * fix build * fix build * ramp up max testing * correct optimization of linear matches * improve diagnostics * fix tests * tests only on .NET Framework for now * fix determinism
|
I don't plan on merging this quite yet, I'm trying to package the nuget locally, flow it through into FSAC, then run tests against known-bad solutions and projects with ionide pointing to an updated FSAC instance to verify. (Plus there are workflow things that need to be worked out in this repository to enable publishing of prerelease packages) |
* cleanup commas * fix indentation * Update IlxGen.fs * apply formatting to additional files * improve output of script * improve output of script
* cleanup comments * cleanup primes
This addresses a situaltion where if you request a tooltip for an operator with a constraint no symbol is returned due to:
Item.ImplicitOp(_, { contents = Some(TraitConstraintSln.FSMethSln(_, vref, _)) })
Being turned into a vanilla FSharpSymbol which has no real information about the symbol that the IDE can use.
An corresponding issue was logged for ionide here: ionide/ionide-vscode-fsharp#1025
Corresponding PR at FCS: fsharp#896
* cleanup semicolons (ugh) * fix build * a little more cleanup * little bit more cleanup * little bit more cleanup * little bit more documentation * little bit more docs * whitespace cleanup and docs * more whitespace and code formatting * little bit more docs * add diagnostics * add diagnostics * add diagnostics * diagnostics * diagnostics * diagnostics * add diagnostics and possible fix for tp smoke tests * fix build * fix build
* Set compiler libraries to netstandard2.0" * Clean up #ifs * Standardize on NETSTANDARD * more
* spacing for commas and colons * code review
|
There's a fix identified and almost merged in VF#, I'll wait for that change to merge into upstream and then reintegrate before releasing a new version. |
baronfel
changed the title
baronfel
force-pushed
the
integrate-vfsharp-feb-25-to-mar-02
branch
from
16762c4 to
b7ec69d
Compare
…321.3 (#6366) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19171.3
* Re-enable ngen for desktop compilers * Go even earlier * Cooler mechanism
* update FCS dependencies * update FCS dependencies * fix up build * code review
baronfel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate visualfsharp master from efb57cf to af97b92.