Skip to content

update edge linewidth to compatible with the released ggplot2 (>=3.4.0) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

xiangpin
Copy link
Contributor

@xiangpin xiangpin commented Feb 8, 2023

The size of some geom in ggplot2 >= (3.4.0) had been replaced with linewidth. see the tidyverse/ggplot2#4959. The original edge_size parameters did not work to adjust the width of edge. This pr has fixed this issue.

> library(ggVennDiagram)
> x <- list(A=1:5,B=2:7,C=3:6,D=4:9)
> p1 <- ggVennDiagram(x)
> p2 <- ggVennDiagram(x, edge_size = 4)
> p1 + p2

捕获

Copy link
Owner

@gaospecial gaospecial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@gaospecial gaospecial merged commit 3178bb0 into gaospecial:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants