-
Notifications
You must be signed in to change notification settings - Fork 21
Add MBC registers, combined PAD
masks, and color bits
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The 5.0 PR #58 was merged rather abruptly, so if anyone has suggestions for what to change/add/remove in it, this can be a good place for them. |
I considered adding an MBC3-only
|
Regarding the suggestion to use conditional Some MBCs have unique registers, like MBC3's RTC latch or MBC7's accelerometer data, which are harmless to define for everyone. (Read the comments or Pan Docs to see which registers are applicable to which MBCs.) Some registers also have unique features, like how MBC5's RAM bank register also controls Rumble, or MMM01's RAM enable register also controls its mapping mode. Again, we can just have MBC-specific mask or value constants that are always defined/available. The only register name that can ever be, not just irrelevant, but wrong, is " As for MBCs with unique registers that use certain addresses instead of their more common roles, those are harmless to always define, and are handled with comments:
|
* Added registers and constants for more MBCs * Added `PAD_*` constants for combined button and Control Pad masks * Added `B_COLOR_*` red/green/blue bit numbers * Corrected comments on `B_BG_PRIO` and `B_OAM_PRIO`
Update the HISTORY.md date before merging!
; **
per-MBC headings, grouping the usual; --
per-register ones).These are all new constants; nothing has been changed, deprecated, or removed.