Skip to content

Add info that associating proguard files with release is optional #13090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Mar 21, 2025

Currently the docs for associating proguard files with releases is not clear enough that it is optional and is not required.

Related: getsentry/sentry#82821

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:37pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:37pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:37pm

@buenaflor buenaflor requested a review from kahest March 21, 2025 16:11
Copy link

codecov bot commented Mar 21, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.67MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.97MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 893.35kB -0.0%
static/chunks/9212-*.js -3 bytes 370.81kB -0.0%
server/middleware-*.js -5.54kB 1.01kB -84.55%
server/middleware-*.js 5.54kB 6.55kB 547.23% ⚠️
static/EM6J6IP75gfszwIfdW5Oh/_buildManifest.js (New) 581 bytes 581 bytes 100.0% 🚀
static/EM6J6IP75gfszwIfdW5Oh/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/KsYLdJEYjqJhWTW1jufyu/_buildManifest.js (Deleted) -581 bytes 0 bytes -100.0% 🗑️
static/KsYLdJEYjqJhWTW1jufyu/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
7517.js -3 bytes 1.66MB -0.0%
../instrumentation.js -3 bytes 908.31kB -0.0%
7688.js -3 bytes 884.28kB -0.0%

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small wording suggestions, otherwise lgtm, thanks!

@buenaflor buenaflor merged commit a10498b into master Mar 24, 2025
11 checks passed
@buenaflor buenaflor deleted the buenaflor/proguard branch March 24, 2025 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants