fix(feedback): update docs with SwiftUI notes #14227
Open
+87
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 860.99kB (4.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
noahsmartin
approved these changes
Jul 3, 2025
coolguyzone
reviewed
Jul 7, 2025
| @@ -57,7 +57,7 @@ The following options can be configured for the integration in `SentryUserFeedba | |||
| | Option | Type | Default | Description | | |||
| | ---------------- | ------------------------- | --------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | `location` | `[NSDirectionalRectEdge]` | `[.bottom, .trailing]` | The location of the widget on the screen. | | |||
| | `autoInject` | `Bool` | `true` | Injects the Feedback widget into the application when the integration is added. Set `autoInject: false` if you want to call `feedback.attachTo()` or `feedback.openDialog()` directly, or only want to show the widget on certain views. | | |||
| | `autoInject` | `Bool` | `true` | Injects the Feedback widget into the application when the integration is added. Set `autoInject: false` if you want to call `SentrySDK.feedback.showWidget()` directly, e.g. to show the widget on certain views. | | |||
There was a problem hiding this comment.
The SentrySDK.feedback.showWidget() seems to be breaking the formatting on this page, I wonder if there's a way to reformat this table so that things fit?
There was a problem hiding this comment.
I think this should be fixed at the docs site level. Why do we force the content to a max width here, leaving all the empty space at the end?
There was a problem hiding this comment.
I'm preparing two options for your consideration here:
- allow specifying docs pages as full width if their content requires it #14375 allows docs pages to specify a full width layout
- provide more space for docs page content #14376 would make the content area a bit larger on all docs pages
coolguyzone
reviewed
Jul 7, 2025
coolguyzone
reviewed
Jul 7, 2025
coolguyzone
reviewed
Jul 7, 2025
coolguyzone
requested changes
Jul 7, 2025
Co-authored-by: Alex Krawiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Updates the docs for Apple User Feedback to at notes about current limitations of using the feature with SwiftUI, related to getsentry/sentry-cocoa#5053.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: