-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Inject manifest into client for turbopack builds #16902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Brice Friha <[email protected]>
size-limit report 📦
|
packages/nextjs/src/config/turbopack/constructTurbopackConfig.ts
Outdated
Show resolved
Hide resolved
packages/nextjs/src/config/turbopack/constructTurbopackConfig.ts
Outdated
Show resolved
Hide resolved
packages/nextjs/src/config/turbopack/constructTurbopackConfig.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Turbopack Configuration Fails for Canary Versions
The isTurbopackSupported
variable is incorrectly set to only isSupportedVersion
before isSupportedCanary
is defined. This prevents Turbopack configuration from being applied to supported Next.js canary versions (e.g., 15.3.0-canary.28+), despite them being compatible. It should be set to supportsClientInstrumentation
(which correctly includes canary versions) after isSupportedCanary
is calculated.
packages/nextjs/src/config/withSentryConfig.ts#L267-L268
sentry-javascript/packages/nextjs/src/config/withSentryConfig.ts
Lines 267 to 268 in 87910e6
(major === 15 && minor === 3 && patch > 0)); | |
isTurbopackSupported = isSupportedVersion; |
Was this report helpful? Give feedback by reacting with 👍 or 👎
ref #16683
This PR injects the manifest into client bundles for turbopack.