Skip to content

feat(nextjs): Inject manifest into client for turbopack builds #16902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 15, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jul 10, 2025

ref #16683

This PR injects the manifest into client bundles for turbopack.

@chargome chargome self-assigned this Jul 10, 2025
Copy link
Contributor

github-actions bot commented Jul 10, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.88 kB - -
@sentry/browser - with treeshaking flags 22.35 kB - -
@sentry/browser (incl. Tracing) 39.75 kB - -
@sentry/browser (incl. Tracing, Replay) 77.88 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.58 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.68 kB - -
@sentry/browser (incl. Feedback) 40.58 kB - -
@sentry/browser (incl. sendFeedback) 28.56 kB - -
@sentry/browser (incl. FeedbackAsync) 33.46 kB - -
@sentry/react 25.61 kB - -
@sentry/react (incl. Tracing) 41.72 kB - -
@sentry/vue 28.31 kB - -
@sentry/vue (incl. Tracing) 41.53 kB - -
@sentry/svelte 23.9 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.44 kB - -
CDN Bundle (incl. Tracing, Replay) 75.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.91 kB - -
CDN Bundle - uncompressed 73.54 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.99 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.18 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.99 kB - -
@sentry/nextjs (client) 43.32 kB - -
@sentry/sveltekit (client) 40.2 kB - -
@sentry/node 167.63 kB - -
@sentry/node - without tracing 100.33 kB - -
@sentry/aws-serverless 128.44 kB - -

View base workflow run

@chargome chargome marked this pull request as ready for review July 13, 2025 15:12
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@chargome chargome requested review from mydea and AbhiPrasad July 14, 2025 12:29
@chargome chargome requested a review from RulaKhaled July 14, 2025 12:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Base automatically changed from cg-next-manifest-webpack to develop July 15, 2025 08:34
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Turbopack Configuration Fails for Canary Versions

The isTurbopackSupported variable is incorrectly set to only isSupportedVersion before isSupportedCanary is defined. This prevents Turbopack configuration from being applied to supported Next.js canary versions (e.g., 15.3.0-canary.28+), despite them being compatible. It should be set to supportsClientInstrumentation (which correctly includes canary versions) after isSupportedCanary is calculated.

packages/nextjs/src/config/withSentryConfig.ts#L267-L268

(major === 15 && minor === 3 && patch > 0));
isTurbopackSupported = isSupportedVersion;

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@chargome chargome merged commit e67ba06 into develop Jul 15, 2025
51 checks passed
@chargome chargome deleted the cg-next-manifest-turbopack branch July 15, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants