ref(vercel-edge): Use debug in vercel edge sdk
#16912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
chargome
and removed request for
a team
mydea
reviewed
Jul 11, 2025
packages/vercel-edge/src/sdk.ts
Outdated
| */ | ||
| function setupOpenTelemetryLogger(): void { | ||
| const otelLogger = new Proxy(logger as typeof logger & { verbose: (typeof logger)['debug'] }, { | ||
| const otelLogger = new Proxy(debug as typeof debug & { verbose: (typeof debug)['log'] }, { |
There was a problem hiding this comment.
hmm do we even need this? Can we not directly set e.g. { error: debug.error, warn: debug.warn, ... } then here?
There was a problem hiding this comment.
(which imho is much nicer than the proxy anyhow)
There was a problem hiding this comment.
I agree, will make the change! I just blindly copied the pattern (just assumed it was there for some reason I couldn't understand 😄)
chargome
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16911