Skip to content

ref(vercel-edge): Use debug in vercel edge sdk #16912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025

Conversation

AbhiPrasad
Copy link
Member

resolves #16911

@AbhiPrasad AbhiPrasad requested a review from a team July 10, 2025 18:25
@AbhiPrasad AbhiPrasad self-assigned this Jul 10, 2025
@AbhiPrasad AbhiPrasad requested review from mydea and chargome and removed request for a team July 10, 2025 18:25
*/
function setupOpenTelemetryLogger(): void {
const otelLogger = new Proxy(logger as typeof logger & { verbose: (typeof logger)['debug'] }, {
const otelLogger = new Proxy(debug as typeof debug & { verbose: (typeof debug)['log'] }, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm do we even need this? Can we not directly set e.g. { error: debug.error, warn: debug.warn, ... } then here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which imho is much nicer than the proxy anyhow)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, will make the change! I just blindly copied the pattern (just assumed it was there for some reason I couldn't understand 😄)

@AbhiPrasad AbhiPrasad merged commit bcb7422 into develop Jul 14, 2025
328 of 329 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-debug-vercel-edge branch July 14, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate vercel-edge sdk to use debug
3 participants