feat(node): Drop 401-404 and 3xx status code spans by default #16972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to 404, we now also drop 3xx (e.g. 301 MOVED_PERMANTENTLY) spans by default. These are usually not helpful.
andreiborza
approved these changes
Jul 14, 2025
chargome
approved these changes
Jul 14, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
size-limit report 📦
|
andreiborza
reviewed
Jul 14, 2025
| @@ -108,20 +108,3 @@ test('Should send a transaction and an error event for a faulty generateViewport | |||
|
|
|||
| expect(errorEvent.transaction).toBe('Page.generateViewport (/generation-functions)'); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Removed this test because the redirect is no longer sent.
andreiborza
changed the title
|
@mydea updated failing tests and updated the range to 401-404. Could you please have another look? |
|
can't approve, but looks good - merging in ❤️ |
msonnb
pushed a commit
that referenced
this pull request
Jul 15, 2025
In addition to 404, we now also drop 401, 402, 403 and 3xx (e.g. 301 MOVED_PERMANTENTLY) spans by default. These are usually not helpful. Noticed this in some react-router E2E test where 301 spans were messing with the test, but these should not even be captured really. --------- Co-authored-by: Andrei Borza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to 404, we now also drop 401, 402, 403 and 3xx (e.g. 301 MOVED_PERMANTENTLY) spans by default.
These are usually not helpful.
Noticed this in some react-router E2E test where 301 spans were messing with the test, but these should not even be captured really.