Skip to content

ref(nextjs): Allow rollup@^4.35.0 dependency range #17010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 15, 2025

Allows rollup minor and patch versions above 4.35.0 so that rollup dependencies specifying a similar version range can be better deduped.

No strong opinions on getting this in but it came up in #16971. If anyone has concerns we can also close it (or safely revert in case we get reports later on).

closes #16971

@Lms24 Lms24 self-assigned this Jul 15, 2025
@Lms24 Lms24 requested review from chargome and RulaKhaled July 15, 2025 08:29
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is reasonable IMHO, we should not depend on a specific version of rollup here I suppose.

Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.88 kB - -
@sentry/browser - with treeshaking flags 22.35 kB - -
@sentry/browser (incl. Tracing) 39.75 kB - -
@sentry/browser (incl. Tracing, Replay) 77.88 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.58 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.68 kB - -
@sentry/browser (incl. Feedback) 40.58 kB - -
@sentry/browser (incl. sendFeedback) 28.56 kB - -
@sentry/browser (incl. FeedbackAsync) 33.46 kB - -
@sentry/react 25.61 kB - -
@sentry/react (incl. Tracing) 41.72 kB - -
@sentry/vue 28.31 kB - -
@sentry/vue (incl. Tracing) 41.53 kB - -
@sentry/svelte 23.9 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.44 kB - -
CDN Bundle (incl. Tracing, Replay) 75.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.91 kB - -
CDN Bundle - uncompressed 73.54 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.99 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.18 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.99 kB - -
@sentry/nextjs (client) 43.32 kB - -
@sentry/sveltekit (client) 40.2 kB - -
@sentry/node 167.61 kB -0.02% -24 B 🔽
@sentry/node - without tracing 100.3 kB -0.03% -29 B 🔽
@sentry/aws-serverless 128.41 kB -0.03% -29 B 🔽

View base workflow run

@Lms24 Lms24 enabled auto-merge (squash) July 15, 2025 08:37
@Lms24 Lms24 merged commit a3b4501 into develop Jul 15, 2025
172 checks passed
@Lms24 Lms24 deleted the lms/ref-nextjs-rollup-caret-version-range branch July 15, 2025 08:46
msonnb pushed a commit that referenced this pull request Jul 15, 2025
Allows rollup minor and patch versions above 4.35.0 so that rollup
dependencies specifying a similar version range can be better deduped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed version of rollup causes package duplication
3 participants