feat(nuxt): Align build-time options to follow bundler plugins structure #17255
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| /** | ||
| * When an error occurs during release creation or sourcemaps upload, the plugin will call this function. | ||
| * | ||
| * By default, the plugin will simply throw an error, thereby stopping the bundling process. |
There was a problem hiding this comment.
Unless I'm mistaken, by default the plugin fails gracefully by printing the error but not exiting the build process.
There was a problem hiding this comment.
The docs are taken from here: https://www.npmjs.com/package/@sentry/vite-plugin#errorhandler
If this is not correct, we should also fix it in the bundler-plugins readme.
| org: moduleOptions.org ?? sourceMapsUploadOptions.org ?? process.env.SENTRY_ORG, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| project: moduleOptions.project ?? sourceMapsUploadOptions.project ?? process.env.SENTRY_PROJECT, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| authToken: moduleOptions.authToken ?? sourceMapsUploadOptions.authToken ?? process.env.SENTRY_AUTH_TOKEN, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| telemetry: moduleOptions.telemetry ?? sourceMapsUploadOptions.telemetry ?? true, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| url: moduleOptions.sentryUrl ?? sourceMapsUploadOptions.url ?? process.env.SENTRY_URL, | ||
| headers: moduleOptions.headers, | ||
| debug: moduleOptions.debug ?? false, | ||
| silent: sourceMapsUploadOptions.silent ?? false, | ||
| errorHandler: sourceMapsUploadOptions.errorHandler, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| silent: moduleOptions.silent ?? sourceMapsUploadOptions.silent ?? false, | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| errorHandler: moduleOptions.errorHandler ?? sourceMapsUploadOptions.errorHandler, | ||
| bundleSizeOptimizations: moduleOptions.bundleSizeOptimizations, // todo: test if this can be overridden by the user |
There was a problem hiding this comment.
l/just to confirm: Did we settle on the new build time options taking precedence over the old ones? I think this is generally fine (as fine as vice versa) but let's make sure we're consistent with this behaviour across sdks. (also doesn't hurt to write it down in the issue).
There was a problem hiding this comment.
Yeah we didn't specifically talk about that but I thought it makes sense as it makes migration easier as well. I'll write it down 👍
| @@ -0,0 +1,129 @@ | |||
| import { describe, expectTypeOf, it } from 'vitest'; | |||
Aligns the build-time options of the Nuxt SDK and implements the missing options.
Closes #17064