fix(browser): Ensure request from diagnoseSdkConnectivity doesn't create span
#17280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
diagnoseSdkConnectivity does not create spandiagnoseSdkConnectivity doesn't create span
andreiborza
approved these changes
Aug 1, 2025
dev-packages/browser-integration-tests/suites/public-api/diagnoseSdkConnectivity/test.ts
Outdated
Show resolved
Hide resolved
…oseSdkConnectivity/test.ts Co-authored-by: Andrei <[email protected]>
andreiborza
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
diagnoseSdkConnectivityAPI makes afetchPOST request to Sentry's ingestion endpoint to simulate an actual SDK request. This API is injected into the example pages created by our wizards when setting up Sentry.Usually, our SDK does not create spans or breadcrumbs for SDK-made requests to Sentry. However, for browser
fetch, we do this by simply obtaining an unpatchedfetchcall in our transport. So we don't have a check in our fetch tracing instrumentation that bails if it encounters a Sentry ingestion endpoint URL. (In contrast, our XHR instrumentation does exactly that.)This PR therefore ensures that we suppress tracing (and breadcrumbs) for
diagnoseSdkConnectivity-made requests.suppressTracingworks well here. We could also get an native fetch implementation here but I'd say we only try this if for some reasonsuppressTracingdoesn't work.closes https://linear.app/getsentry/issue/BE-542/investigate-spans-issue-in-ingest-since-version-10