fix(sessions): clean up threading on kill+flush #4562
Draft
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4562 +/- ##
==========================================
- Coverage 80.68% 80.65% -0.03%
==========================================
Files 156 156
Lines 16482 16494 +12
Branches 2802 2805 +3
==========================================
+ Hits 13299 13304 +5
- Misses 2299 2306 +7
Partials 884 884
|
|
This needs test coverage, apparently. Any hints? I'll do the work. |
sl0thentr0py
requested changes
Jul 9, 2025
sentry_sdk/sessions.py
Outdated
| def _thread_stopping(self): | ||
| # type: (...) -> bool | ||
| return ( | ||
| not self._running |
There was a problem hiding this comment.
there's no more self._running so will wait till you rebase on the other change
This follows the precedent set in transport.flush, and helps me with my project to assert thread hygeine in sentry test suite (related: DI-1008), but also makes the system much more deterministic for everyone. This will cause shutdown to be quite slow until #4561 goes in. So I'd reject this if you reject that.
bukzor
force-pushed
the
bukzor/can-wait4-session-flusher
branch
from
cf8a3ed to
8d24e88
Compare
sl0thentr0py
reviewed
Jul 9, 2025
| @@ -190,14 +191,34 @@ def flush(self): | |||
| if len(envelope.items) > 0: | |||
| self.capture_func(envelope) | |||
|
|
|||
| # hygiene: deterministically clean up any stopping thread | |||
| if not self._should_join_thread(): | |||
There was a problem hiding this comment.
why are two of these required? isn't the one under the lock sufficient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the precedent set in BackgroundWorker.flush, and helps me with my project
to assert thread hygeine in sentry test suite (related: DI-1008), but also makes
the system much more deterministic for everyone.
This will cause shutdown to be quite slow until #4561 goes in. So I'd reject
this if you reject that.